Closed stefanpenner closed 3 years ago
Interesting. How does calling process.exit(1)
mean the process exits with the wrong code? I frequently do this in my own code. What's the benefit of setting process.exitCode
first?
It doesn’t, process.exitCode
just a more cooperative (IMHO better) way to exit with the status code of choice. Rather than explicitly ending the process, this approach allows the process to naturally shut down, ultimately exiting with w/e the final state of process.exitCode
is.
This PR is fixing a bug, specifically the bug fix here was adding a missing exitCode assignment (see above inline comment)
Oh, I see! I had missed that there was an new exit scenario in there.
Something new for this PR @stefanpenner @rwjblue ?
released as v3.5.1 🎉
…de on build failure