broccolijs / broccoli

Browser compilation library – an asset pipeline for applications that run in the browser

https://broccoli.build

MIT License

3.33k stars 217 forks source link

[fix] running lint as a seperate CI task and fixes all errors to ensure CI passes #463

Closed gabrielcsapo closed 4 years ago

gabrielcsapo commented 4 years ago

fixes #437

Motivation

To ensure that linting is run. The previous linting setup was not catching all issues before they were submitted.

I had to turn off no-unused-vars because it does not currently work with imported types. The issue here https://github.com/typescript-eslint/typescript-eslint/issues/1856.

gabrielcsapo commented 4 years ago

@rwjblue I found a bug in lib/cli.js it looks like we were passing a string but it was expecting an error instance. Which would silently fail and cause the ui to write undefined.

gabrielcsapo commented 4 years ago

bump on merging this as it fixes an error with ui.writeError as well