Exit process with code 1 when build fails

broccolijs / broccoli

Browser compilation library – an asset pipeline for applications that run in the browser

https://broccoli.build

MIT License

3.33k stars 217 forks source link

Exit process with code 1 when build fails #472

Closed chiragpat closed 4 years ago

chiragpat commented 4 years ago

Why Currently when a build fails broccoli-cli exits with code 0. This causes a lot of different tools that rely on exit code to assume that build succeeded even though it in fact failed

How

Added a flag buildFailed and toggled it if the catch block is invoked
Swapped exit code to 1 in the finally block based on that flag

stefanpenner commented 4 years ago

https://github.com/broccolijs/broccoli/pull/456 requires a test be written for one scenario. Rather than landing this PR, could you help address that test? That way, we address all the issues in one step.

chiragpat commented 4 years ago

456 requires a test be written for one scenario. Rather than landing this PR, could you help address that test? That way, we address all the issues in one step.

Yup I missed that PR when I created this one. I will go ahead and add a test to that PR.

chiragpat commented 4 years ago

Closing this PR in favor of adding a test to #456