search

broccolijs / broccoli

Browser compilation library – an asset pipeline for applications that run in the browser
https://broccoli.build
MIT License
3.33k stars 217 forks source link

Manually exit process #478

Closed asakusuma closed 3 years ago

asakusuma commented 3 years ago

Partial revert of https://github.com/broccolijs/broccoli/pull/476 to work around https://github.com/babel/broccoli-babel-transpiler/issues/169

Kept the tests and ensuring the correct exit code is called, but put back the manual process exiting.

asakusuma commented 3 years ago

The one failing job seemed to hit an unrelated tooling error:

info There appears to be trouble with your network connection. Retrying...
error An unexpected error occurred: "https://registry.yarnpkg.com/rxjs/-/rxjs-6.5.2.tgz: ESOCKETTIMEDOUT".
info If you think this is a bug, please open a bug report with the information provided in "/Users/runner/work/broccoli/broccoli/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
Error: Process completed with exit code 1.
rwjblue commented 3 years ago

Re-ran CI (yarn install failed on macOS)

stefanpenner commented 3 years ago

This is a workaround, could an inline comment be added describing the rationale?

The proper solution is a little more involved, and requires adding a destructor concept to broccoli pipelines, and plugins.

stefanpenner commented 3 years ago

opened an issue: https://github.com/broccolijs/broccoli/issues/479