Kirby Package Manager and gitignore

illycz commented 6 years ago

Would it be possible to add plugins to .gitignore configurable? I don't think everyone is using CI.

What do you think?

pqml commented 6 years ago

Not sure to understand what you want

A lot of features are missing from Kirby Package Manager

We really need to add some kind of version control (possibly based on git hash because a lot of kirby plugins don't make releases or don't update package.json version number)
We also need an unlink feature to simply download a plugin without putting it in the .gitignore. I have to do this manually on projects using CI to avoid breaking them if a plugin makes breaking changes

We made a repo to move kirby package manager outside the kirby webpack boilerplate but didn't start to work on it https://github.com/brocessing/kirby-package-manager

illycz commented 6 years ago

I meant the option to cancel adding plugin to .gitignore when I use Kirby Package Manager...

arnaudjuracek commented 6 years ago

So what you're proposing is something along the line of npm run kirby:add --no-gitignore ?

illycz commented 6 years ago

Yes or Kirby option in config file...

arnaudjuracek commented 6 years ago

Commit 72a4e07a0edba408cbeaebbcedd979a045f2613e adds the --no-ignore flag to kirby:add

Upgrade to 0.7.3 to be able to run :

$ yarn kirby:add --no-ignore
$ npm run kirby:add -- --no-ignore

brocessing / kirby-webpack