Thanks so much for creating a pull request! You are an awesome person, and you should feel good about yourself!! 😄 On to the PR...
I'm okay with the concept of adding an option for --only-remove, but when I tested this, the prompts felt just like the node-reinstall prompts, and I could imagine a new user feeling confused. I think this task deserves it's own prompts so that the user knows exactly what they are getting.
Here's an example. For a new user trying to uninstall node, this might be confusing:
This made it look like we were going to re-install Node.js, even though we'd explicitly said --only-remove.
If we go this route, I think we should move the remove functionality into a separate function and make it a little more clear that we aren't going to re-install node or npm. That way we could do more customized messaging to the user so they know this is just a wipe without a re-install.
Thanks so much for creating a pull request! You are an awesome person, and you should feel good about yourself!! 😄 On to the PR...
I'm okay with the concept of adding an option for
--only-remove, but when I tested this, the prompts felt just like thenode-reinstallprompts, and I could imagine a new user feeling confused. I think this task deserves it's own prompts so that the user knows exactly what they are getting.Here's an example. For a new user trying to uninstall node, this might be confusing:
This made it look like we were going to re-install Node.js, even though we'd explicitly said
--only-remove.If we go this route, I think we should move the remove functionality into a separate function and make it a little more clear that we aren't going to re-install node or npm. That way we could do more customized messaging to the user so they know this is just a wipe without a re-install.