search

brock / node-reinstall

Complete Node Reinstall for OSX and Linux
http://git.io/node-reinstall
544 stars 72 forks source link

Responses to PRs #48

Open brock opened 5 years ago

brock commented 5 years ago

I apologize to all of you that submitted Issues and Pull Requests. You are all WONDERFUL people and you should feel good about yourselves, because I called my mom and specifically asked her about each of you and she call YOUR moms and reported back that you all are, IN FACT, WONDERFUL PEOPLE!

This PR will hopefully address some of the many issues that have been raised. But I'm pretty good at breaking things, and in my tests, yes, there were a few rare cases that did break, but for the most part things worked, so I'm shipping it.

VERSION 0.0.18 includes the following, and please let me know if any of you have any issues after this version:

38 Capture output when Node isn't found - Thank you @bladnman

45 Handle Arch users (insert Reddit jab here), but seriously, thank you @peternann

46 I took your advice and am getting the nvm version from their package.json - thanks @mlbrgl

brock commented 5 years ago

If any of you WONDERFUL PEOPLE want to test this before it goes live, I'll give this a day before I merge.