Closed DavidChristiansen closed 7 years ago
For 2fa codes? Not sure how much effort this would be to rework MR's semantics around this... but you're saying you did this already?
I have a rough working prototype which I am planning on completing and making releasable. You interested? Do you think there would be a demand for this feature?
I think having an option for something other than SMS is great. Maybe we can chat over skype and see what you have.
Working Time-based One-time Password example ready to demonstrate.
User clicks "Configure Authenticator"
User adds Membership Reboot Sample to authenticator app, and tells the sample the code generated by Authenticator. This is confirmed and user is good to go.
New two factor auth option
Checked into my fork / branch -- https://github.com/DavidChristiansen/BrockAllen.MembershipReboot/tree/feature/RFC-6238
Once we have talked this over, I think can strip out the CSS changes etc so a PR is purely RFC-6238 (unless you want the UI changes aswell)
I just got back from holiday, so you'll have to give me some time to get to this. Thx.
It seems the fork @ https://github.com/DavidChristiansen/BrockAllen.MembershipReboot/tree/feature/RFC-6238 is not longer there... has it moved somewhere, or is there another implementation of TOTP somewhere else?
Thanks, - Eric
Hi Eric, The PR was resubmitted under #594 - needs to be updated in line with recent changes but its all there. Brock and I just need to sit down for an hour to go through it before it goes in.
Ah great, thanks David! We are doing a two factor project, and this is something we'll want to add. It's great it's so close. If we get to that point before you've gotten to it, I'll be happy to help. Until then, we're just working hard to get version one of our project going...
Any idea about when this might be completed? It is a feature we would love to have in our system, as SMS-delivery is not very reliable in all corners of the world.
Implemented to Dev branch
I have added support for the HMAC-Based One-time Password (HOTP) algorithm specified in RFC 4226 and the Time-based One-time Password (TOTP) algorithm specified in RFC 6238 to enable the use of Microsoft and Google authenticator as 2fa mechanism.
Please assign to me if you want this feature brought back into github.
ticket originally created in error here