search

brockallen / BrockAllen.MembershipReboot

MembershipReboot is a user identity management and authentication library.
Other
742 stars 238 forks source link

RFC 6238 implementation and sample #594

Closed DavidChristiansen closed 7 years ago

brockallen commented 8 years ago

I think this PR is dead, no? It's quite out of sync now.

DavidChristiansen commented 8 years ago

Well it can be brought back in line. We never did catch up to go over it. It's a good feature and implemented, so let's not throw it away

brockallen commented 8 years ago

Okies.

amd989 commented 7 years ago

I have created a fork with the merge. Fork #688 So far, I only got 3 hard conflicts mainly with the readme, and resources.

I've been getting familiarized with this PR for a while, I have tested its functionality and seems to be working fine. No weird errors ATM.

The only thing I would add, is the ability to generate secrets based on a configuration property rather than hard-coded value, allowing secrets to be bigger if needed.

DavidChristiansen commented 7 years ago

@brockallen Things are in sync now - Over to you for final pull.

DavidChristiansen commented 7 years ago

Given that Brock has stated that he is no longer in a position to maintain MBR, I have taken the decision to merge this PR into Dev. All compiles/green based on current head.

DavidChristiansen commented 7 years ago

Note: You may require to perform a DB migration to reflect schema changes to the UserAccount object.