search

brockallen / BrockAllen.MembershipReboot

MembershipReboot is a user identity management and authentication library.
Other
742 stars 238 forks source link

Account Creation changes #604

Closed christianacca closed 8 years ago

christianacca commented 8 years ago

Bug fixes and enhancements to code related to account creation

brockallen commented 8 years ago

Any tests to add, perhaps? :)

christianacca commented 8 years ago

No probs

christianacca commented 8 years ago

Brock, I've added some tests to the original commit. Plus another commit that adds EmailVerifiedEvent.IsNewAccount property.

I don't think I see any other changes on this PR so I'm going to merge to master tomorrow if that's OK with you?

Thanks C

brockallen commented 8 years ago

you have the power!

christianacca commented 8 years ago

Cool :-)

brockallen commented 8 years ago

BTW, was this a breaking change? IOW, how likely would this break any existing code?

christianacca commented 8 years ago

No breaking changes, just a tiny new feature. If you're following semver you would bump to 8.5.0...

brockallen commented 8 years ago

Ok, great. thanks.