brockallen / BrockAllen.MembershipReboot

MembershipReboot is a user identity management and authentication library.
Other
742 stars 238 forks source link

Support for Account approval proccess #634

Closed christianacca closed 7 years ago

christianacca commented 8 years ago

See https://github.com/brockallen/BrockAllen.MembershipReboot/issues/632

christianacca commented 8 years ago

PR summary

christianacca commented 8 years ago

Hi @brockallen, a decision needs to be made whether - feat(EmailNotification): send email when account is unlocked (or https://github.com/brockallen/BrockAllen.MembershipReboot/commit/277607b0b77d50c2356ea4d6449bdf0c4cb4e9bd) - over on master is a breaking change.

My gut feel is that it is a breaking change - the new emails that would be sent would not follow any branding customizations that maybe being applied by host app using MR.

If it is I'll update the nuspec files accordingly on master, then update this PR before merging into master...

If I don't here back (which is fine of course), I'll take a safe position and update the nuspec files to be a breaking change.