search

brockallen / BrockAllen.MembershipReboot

MembershipReboot is a user identity management and authentication library.
Other
742 stars 238 forks source link

Support for non-unique certificates #656

Closed mirecg closed 7 years ago

mirecg commented 8 years ago

Support for allowing non-unique certificates in user accounts through configuration property CertificateIsUnique, which is true by default (this is original behavior) as discussed in #645.

brockallen commented 7 years ago

Given that I don't foresee making this change, I'll close this issue. Thanks.

EsaHub commented 7 years ago

Hi brockallen,

for this issues you said "I don't foresee making this". Do you have some special reason for reject this issue? Some security issue? Or some other? (Some other than your work bandwidth only)

I'd like that mobile number is unique, but real life is many times different.

Our company has been used your great membershipreboot component. Currently in production we have problem that some customers (companies and their employees) does not have personal mobile numbers/devices. It means that it should be possible to add non unique mobile number for different user account.

If you don't agree this pull request, do u see any risk (e.g. security or some other) that we can take to use this kind of functionality?

brockallen commented 7 years ago

Mainly time/bandwidth. And without the time, I don't want to add a feature such as this that requires time to think about the security ramifications.

Does Google allow re-use of the same mobile number for 2fa?