brockchamb / git-osx-installer

Automatically exported from code.google.com/p/git-osx-installer
0 stars 0 forks source link

OpenInGitX Droplet Does not work #63

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Install droplet according to instructions
2. Click on it with a repository directory selected in the finder
3. Nothing happens

What is the expected output? What do you see instead?

What version of the product are you using? On what operating system?
OpenInGitX-1.1, on Snow Leopard 10.6.6

Please provide any additional information below.
Yes, I've made sure GitX runs and doesn't give me the dialog, etc.

I have found the problem, and it is with the screen command in the AppleScript. 
It's not necessary for the droplet to work correctly, and, because I have a 
.screenrc that automatically does some things at startup, it fails. Removing 
the "screen -Smd ..." part before the "bash -c" fixes the problem. I've 
attached the fixed source code.

Original issue reported on code.google.com by mywolf...@gmail.com on 6 Feb 2011 at 7:18

Attachments:

GoogleCodeExporter commented 8 years ago
The screen command IS necessary, in my experience, and is very well motivated.  
For some reason, Git can't communicate over SSL unless if Git has a PTY.  
Perhaps there is some other way to achieve it?  See if SSH fetching works for 
you.

It may be better to pass a param to screen to ignore your screenrc... or use a 
custom one.

Original comment by timchar...@gmail.com on 6 Feb 2011 at 7:28

GoogleCodeExporter commented 8 years ago
It seems that "screen -c /dev/null" will properly ignore any .screenrc file.  
I'll upload a new version, thanks for the report.

Original comment by timchar...@gmail.com on 6 Feb 2011 at 7:35

GoogleCodeExporter commented 8 years ago
above, when I said SSL, I meant SSH... I haven't tried fetching over https with 
a PTY-less git process... but... anyways, it definitely does not work on my 
machine without the screen command.

Original comment by timchar...@gmail.com on 6 Feb 2011 at 7:40

GoogleCodeExporter commented 8 years ago
Don't know why my email reply didn't register as a comment on the page. Anyway, 
here it is, for completeness:

On Feb 6, 2011, at 2:41 PM, codesite-noreply@google.com wrote:

> above, when I said SSL, I meant SSH... I haven't tried fetching over https 
with a
> PTY-less git process... but... anyways, it definitely does not work on my 
machine
> without the screen command.

Yeah, the SSH thing is not something I considered, so I did not test it.

Your config-file-less fix worked, however. Thanks!

--
Misha

P.S. After I threw out the screen command, I did have a little twinge that made 
me think "well, it wasn't in there for no reason, was it? And I know it's my 
screen config that's the issue… maybe this isn't The Right Way." Glad you 
pointed me to it.

Original comment by mywolf...@gmail.com on 8 Feb 2011 at 2:10