brockf / membrr

Integrate subscriptions and members-only content into ExpressionEngine.
6 stars 10 forks source link

Subscription Search & Pagination not working #10

Open ljvasey opened 10 years ago

ljvasey commented 10 years ago

I'm not exactly holding my breath for a quick solution to this, due to recent electricfunction abandonment of the product, but hopefully the GitHub community can help :)

Since updating to Membrr 1.81, on EE 2.8.1, I'm no longer able to search or paginate through Subscriptions on the 'Subscriptions' tab of the Membrr interface.

When I attempt a search, I'm simply redirected to the home page of the CP, and when I attempt to paginate, I get the following message:

requested_module_page

The plugin is essentially useless without being able to search through subscriptions, so any help on this would be greatly appreciated.

kylephillips commented 10 years ago

I'm having the same issue running the same versions(1.81, EE v 2.8.1). Would be really nice to get this resolved.

ljvasey commented 10 years ago

Hi Kyle,

FWIW, I've isolated the problem with the pagination, but have not yet been able to resolve it.

The issue is with the URL encoding. When I paginate, the end of the URL comes out as:

membrr&method=subscriptions%26search%3D&rownum=50

Changing %26 and %3D manually to their un-encoded equivalents, & and =, respectively, results in the second page being displayed. After that, changing the value of rownum will let you view the other pages, in increments of 50.

Not sure what's causing this, as the dashboard tab of Membrr doesn't have this issue with pagination. Still no idea what's causing the issue with search.

Will post more here as I have more information.

lonnieezell commented 10 years ago

Hey guys, I don't work on Membrr anymore, but I seem to recall a similar information with the URL encoding happening before. The fix for that was in opengateway.php's Param method. Not sure if this is related, but I'd start checking there if I was you.

ljvasey commented 10 years ago

Thanks Lonnie, will look into this.

kylephillips commented 10 years ago

RE: the search redirection, changing the form in the subscriptions view to POST instead of GET (and adding csrf token) & changing the appropriate input functions in the subscribe method seems to have cleared it up.

I may be missing something, but it seems the only thing lost is the search parameters in the URL.

kylephillips commented 10 years ago

Actually, I see now that those URL parameters are needed in paginated search results

philnorton commented 10 years ago

Quick fix for the pagination... Edit line 2117 in mcp.membrr.php from:

$config['base_url'] = $this->cp_url($method, $parameters);

to

$config['base_url'] = rawurldecode($this->cp_url($method, $parameters));

and that will remove the encoding that prevents the pagination from working properly...

kylephillips commented 10 years ago

Sweet, thanks Phil!

pierrebayartz commented 10 years ago

Is there any patch or PR for this problem? I don't actually get the exact change you've made @kylephillips .

Regards