search

brockpetrie / dynamictextgroup

A Symphony field that provides a method to dynamically add a text field or text field groups to a section entry
22 stars 13 forks source link

Referene to a missing js file in the code #15

Closed andrewminton closed 11 years ago

andrewminton commented 11 years ago

There is a reference to a missing https://github.com/brockpetrie/dynamictextgroup/blob/development/fields/field.dynamictextgroup.php#L188

When you create a field all is good, When you edit a section with dynamictextgroup field the error in layout occurs. When I inspect element I noticed that a reference to the missing script came up.

designermonkey commented 11 years ago

Andrew, does this make the field unusable? I need this in a project.

andrewminton commented 11 years ago

Yes mate, The presentation is all to pot in the Section entry editor.

I've searched Brocks code on all branches and there is no reference to this file in the repo.

designermonkey commented 11 years ago

Damn. Rethinking time then. Cheers Andrew.

andrewminton wrote:

Yes mate, The presentation is all to pot in the Section entry editor.

— Reply to this email directly or view it on GitHub https://github.com/brockpetrie/dynamictextgroup/issues/15#issuecomment-15459444.

andrewminton commented 11 years ago

It may be a refactoring of what JS file is loaded at first build of section with dynamictextgroup and see what is in use there..

I got a feeling there is no need for that bit of code, cos it worked when I first created the section and started adding Dynamic Text Entry Fields.

designermonkey commented 11 years ago

Ok, when I get to that section, I'll take a look at it.

andrewminton wrote:

It may be a refactoring of what JS file is loaded at first build of section with dynamictextgroup and see what is in use there..

I got a feeling there is no need for that bit of code, cos it worked when I first created the section and started adding Dynamic Text Entry Fields.

— Reply to this email directly or view it on GitHub https://github.com/brockpetrie/dynamictextgroup/issues/15#issuecomment-15461778.

andrewminton commented 11 years ago

Tidy..

I'm in there too as well.. local build with 2.3.2 to test it out.. I am using the Development Branch and that's where I'm experiencing this issue.. I think Master branch is fine as it has no reference to the custom select2.custom.js file in there.

designermonkey commented 11 years ago

master isn't compatible with 2.3.x sadly.

I've run into other issues with the JS in this as it's only able to run a single instance of the field, and I haven't got time to rejig it to work for multiple, so have dropped it from the spec.

andrewminton commented 11 years ago

Yeh, I think Multiple instances was on the TODO list for v3.

andrewminton commented 11 years ago

A good duplicator to trump SSM is in dire need of some investment me thinks.. so much promise.. Rowans Content Fieldhttps://github.com/rowan-lewis/content_fieldis quite useful at the moment.

On 26 March 2013 23:25, John Porter notifications@github.com wrote:

master isn't compatible with 2.3.x sadly.

I've run into other issues with the JS in this as it's only able to run a single instance of the field, and I haven't got time to rejig it to work for multiple, so have dropped it from the spec.

— Reply to this email directly or view it on GitHubhttps://github.com/brockpetrie/dynamictextgroup/issues/15#issuecomment-15495365 .

brockpetrie commented 11 years ago

I've removed the line that references the missing file, so this should be fixed now. Thanks Andrew

andrewminton commented 11 years ago

Ahh right, so it just wasn't needed then. Might file a small issue with styling looking all wonky when editing a section entry using develpoment branch.. will test first though.. cheers.