search

brockpetrie / dynamictextgroup

A Symphony field that provides a method to dynamically add a text field or text field groups to a section entry
22 stars 13 forks source link

Fix 'required' checkbox #21

Closed sarahkemp closed 11 years ago

sarahkemp commented 11 years ago

I was in the middle of submitting an issue and looking for more information about the problem and ended up fixing it, see below.

Checking the 'required' checkbox in a field's flyout appears to have no effect (anymore?). I ran into this problem today so I updated to the latest commit on the development branch (was a couple of commits back on the same branch), but the problem persists.

image

When I select the flyout menu to make changes to the field type, I can make the change and it will save when I save the page (the flyout never hides again once it is open however). The 'required' checkbox, though, will not save its value.

Per this question: http://stackoverflow.com/questions/901712/check-checkbox-checked-property-using-jquery - the right way to get the checked status of a checkbox is .is(':checked') - .attr('checked') was coming up undefined in Chrome (didn't test anywhere else...).

Side note, the flyout still never hides once it has been opened. Is that the intended behavior?

brockpetrie commented 11 years ago

Thanks, Sarah! I appreciate the fix!

sarahkemp commented 11 years ago

Thanks for merging. By the way, I found that you can close the flyout by hitting the little x in the corner - stupid me, I thought that would delete the sub-field so I was afraid to click it!