brocksam / pyproprop

Write classes with lots of similar simple defensive properties without the boilerplate

MIT License

3 stars 1 forks source link

Fix method bug #49

Closed brocksam closed 3 years ago

brocksam commented 3 years ago

As reported in issue #48. Merging this PR will close #48.

brocksam commented 3 years ago

@jackirvine97 can you please check that you think this will solve the bug you've encountered and logged in #48 before I go through the process of releasing 0.4.1 on PyPI and conda-forge? Potentially worth adding additional checks to the test suite if we are unsure this has fully fixed all use cases.

codecov[bot] commented 3 years ago

Codecov Report

Merging #49 into master will increase coverage by 1.5%. The diff coverage is 100.0%.

@@           Coverage Diff            @@
##           master     #49     +/-   ##
========================================
+ Coverage    95.1%   96.6%   +1.5%     
========================================
  Files           6       6             
  Lines         450     447      -3     
  Branches       79      79             
========================================
+ Hits          428     432      +4     
+ Misses         17      11      -6     
+ Partials        5       4      -1

jackirvine97 commented 3 years ago

Happy this fixes the bug raised in the minimal reproducer in #48.