search

brocksam / sympy-biomechanics

Examples using sympy.physics.biomechanics
MIT License
0 stars 1 forks source link

Should musculotendon's manage states and inputs of their children (e.g. activation dynamics) #26

Open brocksam opened 1 year ago

brocksam commented 1 year ago

In the current implementation of MusculotendonDeGroote2016 we pass in an instance of FirstOrderActivationDeGroote2016 to the activation_dynamics parameter. The musculotendon model "owns" the activation dynamics model, so I have the state_vars and input_vars properties set up to return the variables associated with both the musculotendon and activation dynamics models. I think this is helpful but it might be unexpected by the user and we be better off requiring them to pull the state and input variables from both the musculotendon model as well as the activation dynamics model separately.

brocksam commented 1 year ago

Comment copied from now-closed issue https://github.com/brocksam/sympy-biomechanics/issues/21#issuecomment-1683779949

moorepants commented 1 year ago

I haven't explored the Musculotendan design yet, but I currently have imagined an Actuator that either has state or doesn't. The all have inputs and outputs. You called the MusculoTendon an actuator (and it subclasses from one), so I think I would expect to find the state on the actuator.