Restructure code-base - Githubissues

brodbeck-m / dolfinx_eqlb

Efficient reconstruction of H(div) conforming fluxes in FEniCSx. These fluxes can be used to calculate a posteriori error estimates for adaptive FEM calculations.

GNU Lesser General Public License v3.0

2 stars 0 forks source link

Restructure code-base #40

Closed brodbeck-m closed 1 day ago

brodbeck-m commented 1 week ago

With the side-by-side implementation of the Ern and Vohralik as well as the semi-explicit strategy a lot of code files are currently duplicated. This makes the code hard to read.

Restructure the code with sub-modules common, eqlbse, eqlbev and lsolver with basic structure as in dolfinx.

Sub-module base:

[x] QuadratureRule
[x] KernelData
[x] BoundaryData and FluxBC
[x] Patch (PatchType, PatchFacetType + BaseClass)
[x] Selected functions from utils
[x] The local solver

Sub-modul eqlbse:

[x] Patch (combine classes PatchCstm and PatchFluxCstm)
[x] PatchData
[x] KernelData
[x] equilibration_kernels

Sub-modul eqlbev:

Open until rework!

brodbeck-m commented 6 days ago

Commit 949aa5bd1f80f46548c2d31b0f141dc80d92c879: Patch (Type and FacetType) moved to folder base to avoid naming conflict with common from the dolfinx namespace. A general base-class for patches is missing and will be fixed after the rework of the Ern and Vohralik algorithm (see #3). Build process is adjusted to sub-module structure.

brodbeck-m commented 4 days ago

Clean up utils:

Inline copy_cell_data in commit ceae3ca944a7ebabf432ceefd906bc4aa5d6e6ca
Inline extraction of coefficients in commit 90fc17c18649f0cda8083b401c68a26911860395
Move interpolation_data_facet_rt into KernelData in commit adbcb64493f5bbcc03558b9260c99630531156a6
Use aliases for mdspans to mdspan.hpp in base in commit 2133a412c58234204317d436d26d4867c2f8bc84

brodbeck-m commented 3 days ago

Move basic KrnelData and QadratureRule to basic in commit df5088f07c04e2cf5dd9dab3746706dcdb36966a

brodbeck-m commented 3 days ago

Move definition of BCs to base in commit e40ba5c5d11bfcb508ef7a84483a10b704d74579

brodbeck-m commented 2 days ago

Move local_solver and ProblemData to base in commit e225e15acf0d703c15d485ef0b2abc5104c70ea2

brodbeck-m commented 1 day ago

Move routines for semi-explicit equilibration into se in commit df0c23fa9518e13e480b5af56080e80fcbc9e94c