broderickwang / droiddraw

Automatically exported from code.google.com/p/droiddraw
0 stars 0 forks source link

User input is not validated before being used in xml-file #101

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Add a button on a new workspace.
2. Change the Width-value for the button to '150'
3. Click 'Apply' and then 'Generate.'

What is the expected output? What do you see instead?

The following line is generated in the xml-file:
android:layout_width="150"

The problem is that this is not valid output. At least the Android Eclipse
plugin does not accept this line as valid. The correct line should be:
android:layout_width="150px"

This problem is also that DroidDraw accepts '150', and changes the width of
the button accordingly. 

Expected result could be to show an error dialog when pressing apply that
informs the user that something is wrong with the input and perhaps
information about the expected format.

What version of the product are you using? On what operating system?
DroidDraw 1b13
Ubuntu 9.04
Android Development Tools: 0.9.0.v200904221248-147402

Please provide any additional information below.

Original issue reported on code.google.com by torbjorn...@gmail.com on 26 May 2009 at 12:12

GoogleCodeExporter commented 9 years ago
Issue 154 has been merged into this issue.

Original comment by brendan....@gmail.com on 6 Sep 2010 at 8:14

GoogleCodeExporter commented 9 years ago
This is better now, but still not perfect, so leaving open.

Original comment by brendan....@gmail.com on 6 Sep 2010 at 8:14

GoogleCodeExporter commented 9 years ago
Issue 106 has been merged into this issue.

Original comment by brendan....@gmail.com on 6 Sep 2010 at 8:15

GoogleCodeExporter commented 9 years ago
Marking this fixed.  There is now an error dialog.

Original comment by brendan....@gmail.com on 28 Dec 2011 at 6:11