search

brodeurlv / fastnfitness

FastNFitness Android app: Body, Cardio and Fitness tracking.
https://play.google.com/store/apps/details?id=com.easyfitness
BSD 3-Clause "New" or "Revised" License
271 stars 359 forks source link

Progress images #268

Closed FirstWithThisName closed 11 months ago

FirstWithThisName commented 1 year ago

Add Progress images, Export and import can done via ZIP-Files. See https://github.com/brodeurlv/fastnfitness/issues/177

FirstWithThisName commented 1 year ago

I think some cleanup could be done in the ImageUtil class. But I am uncertain if this the right place to do it.

FirstWithThisName commented 1 year ago

@brodeurlv do you have any feedback for me?

brodeurlv commented 1 year ago

Hi, I don't forget you. I have currently issues with compiling with the new android studio. As soon as I can get it working I'll look at your PR. Thanks.

Le dim. 24 sept. 2023, 18:32, FirstWithThisName @.***> a écrit :

@brodeurlv https://github.com/brodeurlv do you have any feedback for me?

— Reply to this email directly, view it on GitHub https://github.com/brodeurlv/fastnfitness/pull/268#issuecomment-1732614690, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD65NDVQRXC7DHWCNJEC4C3X4BOC3ANCNFSM6AAAAAA422UNPU . You are receiving this because you were mentioned.Message ID: @.***>

FirstWithThisName commented 1 year ago

After just recompiling and installing I got the camera issue as well.

Using the camera in other places fails as well, but in the f-droid version it is still working. My guess it that oldschool method of stream copying broke something, but I am not quite certain yet. Good that you noticed it.

FirstWithThisName commented 1 year ago

Ok, the oldest version I can compile ba96637aab7b319da20e1665ffbe476d7d87db2a has the issue as well.
So i think it is not an issue of the stream copying, but I am uncertain what the problem is I don't get usefull error messages.
@brodeurlv do you got an idea what the problem might be?

brodeurlv commented 11 months ago

Hi @FirstWithThisName , sorry for the delayed answer. I guess it is a incompatibility issue between the crop-image and the android version. We would need to migrate it to the latests versions of the library.