search

brodeurlv / fastnfitness

FastNFitness Android app: Body, Cardio and Fitness tracking.
https://play.google.com/store/apps/details?id=com.easyfitness
BSD 3-Clause "New" or "Revised" License
260 stars 350 forks source link

Regarding other types of exercises #33

Open robinrosenstock opened 5 years ago

robinrosenstock commented 5 years ago

For now we have two categories:

The Body Building exercises are described with: "Repetitions" and "Weight". (And multiple ones can concatenated with "Series".) The Cardio exercises are described with: "Distance" and "Duration".

But there are other exercises, which require different types of descriptions, like:

The App FitNotes defines these types at every exercise (on the exercise level) and not for the whole category as it is done in FastnFitness. I don't know which method is better, but the fact that the Cardio exercises are not visible in the "Exercises" tab/page is not very nice. The Exercises page should contain all exercises, or should'n it?

Personally, I really miss the type "Reps and Duration" for doing callisthenics exercises, which often are static hold exercises. For that I would really like to help, but this needs discussion, because there are multiple ways to implement:

  1. Add a new category: callisthenics (beside Body Building and Cardio (Beta)), where every exercise has "Reps and Duration" as its type.
  2. Combine the two categories: "Body Building and Cardio (Beta)" to one (Maybe: "Workout"?). Then every exercise has its own type as in the list from above, which automatically opens when selecting an exercise.

Number 1. has the problem, that you would propably need even more categories in the future. Also this would (under certain circumstances) duplicate code multiple times. I favor Number 2. Because for now the Cardio is still in Beta and the app is not this big to incorporate such a change. Maybe Number 2 sounds like it is way more complicated, but I guess it would even simplify the UI. Maybe this approach would be better with #30 and often a workout session does not consist of only Body Building exercises only with weight but maybe contain multiple forms of exercises, like cardio for warming-up and stretching exercises (inside the same workout)

Other opinions?

robinrosenstock commented 5 years ago

Almost forgotten: a tempo description can be added for every exercise (how fast you do the exercise)

brodeurlv commented 5 years ago

Hi,

I'm currently merging the 2 fragments Cardio and Fontes. It will be much easier in term of maintenance and evolution. This will be an enabler to add other kind of records.

Thanks for the detailled comments here. It is very helpful.

robinrosenstock commented 5 years ago

Thanks for tackling this.

robinrosenstock commented 5 years ago

I want to empahasize this: FastnFitness should become more general in its exercises and everything (not only for Weight lifting).

brodeurlv commented 5 years ago

yes you're right. I'm progressing on the development but the impact it significant. I need to make sure there is no regression. You can have a look at my MergedUI branch if you want to see in which direction I'm heading. Don't hesitate if you have remarks.

brodeurlv commented 5 years ago

Both cardio and bodybuilding UI are merged in 0.16. I have not addressed other types of exercises but I'm thinking about it for after.

robinrosenstock commented 5 years ago

thank, what about pull request #46 from me. Is it compatible?

brodeurlv commented 5 years ago

I changed some stuff in the machinedetailsfragment so maybe. I didn't have time yet to look in depth into your pull request. One thing so is that I would appreciate if you could make a pull request only targeting the filtering feature. Concerning the menu, I have added to the CSV export the capability to export exercise in the 0.16. I prefer not having a specific menu on each fragment for that. Thank you so much for your participation.

Best regards

Charles

Le jeu. 8 nov. 2018 à 23:18, Robin Rosenstock notifications@github.com a écrit :

thank, what about pull request #46 https://github.com/brodeurlv/fastnfitness/issues/46 from me. Is it compatible?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/brodeurlv/fastnfitness/issues/33#issuecomment-437176486, or mute the thread https://github.com/notifications/unsubscribe-auth/AP3WjmGv-XtKDbMZbUBcr8GxPbJPVpHaks5utK2tgaJpZM4W8Q75 .

vanous commented 5 years ago

Hi all, is there any plan for progress on this one? I now add stuff like Pilates as cardio 1km 45minutes, but am not sure what will it do in the future. Thank you.

robinrosenstock commented 5 years ago

Maybe AMRAP workouts are a bit out of scope for now...