brodieG / unitizer

Easy R Unit Tests
Other
39 stars 6 forks source link

`mergeStates` malformed matrix #212

Closed brodieG closed 7 years ago

brodieG commented 7 years ago

Make sure to carefully review this against #197 to make sure we don't keep re-introducing the same regressions back and forth. Seems like we've dealt with this part of the code several times already. Should also review other old issues for this.

> unitize('datatable')

| Inferred test file location: tests/unitizer/datatable.R

+------------------------------------------------------------------------------+
| unitizer for: unitizer/datatable.R                                           |
+------------------------------------------------------------------------------+

             Pass Fail
 <untitled>     -    1
 data.table     3    -
......................
                3    1

= <untitled> ===================================================================

- Failed -----------------------------------------------------------------------

| The following test failed because the new evaluation does not match the 
| reference value from the store. Overwrite with new result ([Y]es, [N]o, 
| [P]rev, [B]rowse, [R]erun, [Q]uit, [H]elp)?

> library(data.table)
data.table 1.10.0
**********
This installation of data.table has not detected OpenMP support. It will still 
work but in single-threaded mode.
**********
  The fastest way to learn (by data.table authors): https://www.datacamp.com/
courses/data-analysis-the-data-table-way
  Documentation: ?data.table, example(data.table) and browseVignettes("data.
table")
  Release notes, videos and slides: http://r-datatable.com

| Conditions mismatch: 

< .REF$conditions                                                               
> .NEW$conditions                                                               
@@ 1,26 / 1,10 @@                                                               
  Condition list with 5 conditions:                                             
  1. Message in packageStartupMessage("data.table ", v, if (dev) paste0(" IN    
<    DEVELOPMENT built ",  : data.table 1.10.4                                  
>    DEVELOPMENT built ",  : data.table 1.10.0                                  
  2. Message in packageStartupMessage("**********\nThis installation of data.   
     table has not detected OpenMP support. It will still work but in single-   
<    threaded mode. If this a Mac and you obtained the Mac binary of data.table 
<    from CRAN, CRAN's Mac does not yet support OpenMP. In the meantime please  
<    follow our Mac installation instructions on the data.table homepage. If it 
<    works and you observe benefits from multiple threads as others have        
<    reported, please convince Simon Ubanek by sending him evidence and ask him 
<    to turn on OpenMP support when CRAN builds package binaries for Mac.       
<    Alternatives are to install Ubuntu on your Mac (which I have done and works
<    well) or use Windows where OpenMP is supported and works well.\n**********"
<    ) : **********                                                             
>    threaded mode.\n**********") : **********                                  
     This installation of data.table has not detected OpenMP support. It will   
<    still work but in single-threaded mode. If this a Mac and you obtained the 
>    still work but in single-threaded mode.                                    
<    Mac binary of data.table from CRAN, CRAN's Mac does not yet support OpenMP.
<    In the meantime please follow our Mac installation instructions on the     
<    data.table homepage. If it works and you observe benefits from multiple    
<    threads as others have reported, please convince Simon Ubanek by sending   
<    him evidence and ask him to turn on OpenMP support when CRAN builds package
<    binaries for Mac. Alternatives are to install Ubuntu on your Mac (which I  
<    have done and works well) or use Windows where OpenMP is supported and     
<    works well.                                                                
     **********                                                                 
  3. Message in packageStartupMessage("  The fastest way to learn (by data.table

| State mismatch; see `.DIFF$state` for details.

unitizer> Q

| No changes recorded.
Error in mergeStates(items.ref, x@state.new, x@state.ref) : 
  Logic Error: global index mapping matrix malformed; contact maintainer.
| Unexpectedly exited before storing unitizer; tests were not saved or changed.
brodieG commented 7 years ago

Duplicate of #199