brodieG / unitizer

Easy R Unit Tests
Other
39 stars 7 forks source link

Ignored tests that later issue conditions #229

Closed brodieG closed 2 years ago

brodieG commented 7 years ago

Show up as new tests, when really they should be "failed" tests, though obviously a little weird given that they were ignored in the first place.

brodieG commented 2 years ago

I can't reproduce this ATM. The test shows up correctly as failed:

> writeLines("f <- function() invisible(TRUE)\nf()\npi", temp.file)
> unitizer:::read_line_set_vals(c("Y","Y"))
> unitize(temp.file, interactive.mode=TRUE)

| 1/1 test passed; nothing to review.                                           

> writeLines("f <- function() {signalCondition('hi');invisible(TRUE)}\nf()\npi", temp.file)
> unitizer:::read_line_set_vals(c("Q"))
> unitize(temp.file, interactive.mode=TRUE)

+------------------------------------------------------------------------------+
| unitizer for: a.R                                                            |
+------------------------------------------------------------------------------+

             Pass Fail
 <untitled>     1    1
......................
                1    1

- Failed -----------------------------------------------------------------------

| The following test failed because the new evaluation does not match the 
| reference value from the store. Overwrite with new result ([Y]es, [N]o, 
| [P]rev, [B]rowse, [R]erun, [Q]uit, [H]elp)?

> f <- function() {
+     signalCondition("hi")
+     invisible(TRUE)
+ }
> f()

| Value mismatch: 

< .ref                   > .new                 
@@ 1 @@                  @@ 1 @@                
< <object not recorded>  > [1] TRUE             

| Conditions mismatch: 

< .REF$conditions                 
> .NEW$conditions                 
@@ 1 / 1,2 @@                     
< Empty condition list            
> Condition list with 1 condition:
> 1. simpleCondition: hi          

unitizer> Q