Does not follow Laravel's coding style

brodkinca / BCA-Laravel-Inspect

Inspect your code via the Artisan CLI using industry-standard tools.

MIT License

50 stars 8 forks source link

Does not follow Laravel's coding style #8

Open Mulkave opened 9 years ago

Mulkave commented 9 years ago

With code like this:

class MyClass
{
    public function someFunction()
    {
        if ($condition == true) {

        } else {

        }
    }
}

where it should warn me about

brace next to class declaration
if opening brace on new line
else opening brace on new line

As declared in Laravel's coding style guide

brodkin commented 9 years ago

At the time that this project was created, around the first v4 beta, I don't think Laravel had an official coding style. In fact, I don't think that it fully followed PSR-1 for that matter. This would definitely be a worthwhile update but I'm not sure when I'll get to it. I'd accept a PR to include these rules however. It may be worth noting that PHPCS' current version is a release candidate that I've heard will use a different ruleset format so this may want to wait for the full 2.0 release.

Mulkave commented 9 years ago

Right, been trying to find ready sniffs specific for Laravel but got no luck, I'm also in a tight sched right now and can't spare time for this as well, so I guess we'll wait for 2.0!