broese / mcbuild

A custom Minecraft client with advanced auto-building capabilities
26 stars 11 forks source link

Handle failure of choose_dot more gracefully #2

Closed louwers closed 8 years ago

louwers commented 8 years ago

Hi there! I've been using mcbuild and it works beautifully, except for the fact that after 1-15 minutes of building, it always crashes with the following message:

mcproxy: mcp_build.c:1087: choose_dot: Assertion `0' failed.

Can the event that choose_dot fails perhaps be handled more gracefully? For example by trying again or by pausing the build?

broese commented 8 years ago

Thank you for reporting it. I agree, many places in the code handle errors ungracefully with a simple assertion and I will try to address that.

However, I would also like to eliminate the source of the issue. Can you supply more information that would help me reproduce it?

P.S. I see you originally opened another issue trying to compile it on OSX - did it work out for you?

louwers commented 8 years ago

Alright, I'll do some testing!

Nope I've had no luck compiling it on OS X, using Linux now! 😉

broese commented 8 years ago

Sorry for the delay, I finally got to fixing bugs. Please try out the current version - I fixed a really stupid copy-paste bug that calculated the distance to the block incorrectly and ultimately leading to assertion.

louwers commented 8 years ago

Amazing, that seems to have fixed it, no more crashes!