Closed microgold closed 6 years ago
Thanks Mike! And thanks for doing to legwork to get Becca running in 3.x. I would love to make it so that Becca can run in either 2.x or 3.x with no modifications. Do you have a GitHub project with your changes in it that I could download and test? If it all works fine with my 2.x installation, then I could pull your changes in and get your contribution properly documented in the annals of GitHub.
Hi Brandon, I''ll set something up in Guthub so you can reference the changes. Looking forward to experimenting more with Becca and it's potential application. Regards, Mike
Sent via the Samsung GALAXY S® 5, an AT&T 4G LTE smartphone
-------- Original message -------- From: Brandon Rohrer notifications@github.com Date: 11/05/2016 9:26 AM (GMT-05:00) To: brohrer/becca becca@noreply.github.com Cc: Mike Gold mike@microgold.com, Author author@noreply.github.com Subject: Re: [brohrer/becca] Cool App! (#22)
Thanks Mike! And thanks for doing to legwork to get Becca running in 3.x. I would love to make it so that Becca can run in either 2.x or 3.x with no modifications. Do you have a GitHub project with your changes in it that I could download and test? If it all works fine with my 2.x installation, then I could pull your changes in and get your contribution properly documented in the annals of GitHub.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/brohrer/becca","title":"brohrer/becca","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/brohrer/becca"}},"updates":{"snippets":[{"icon":"PERSON","message":"@brohrer in #22: Thanks Mike! And thanks for doing to legwork to get Becca running in 3.x. I would love to make it so that Becca can run in either 2.x or 3.x with no modifications. Do you have a GitHub project with your changes in it that I could download and test? If it all works fine with my 2.x installation, then I could pull your changes in and get your contribution properly documented in the annals of GitHub."}],"action":{"name":"View Issue","url":"https://github.com/brohrer/becca/issues/22#issuecomment-258614973"}}}
Sounds great Mike. I'm working toward making Becca more stable so that it's a fixed target, and it will be easier to integrate with robots and simulations.
Hi Brandon,
I put my Becca 3.5 project here with the changes if you wanted to take a look:
https://github.com/microgold/Becca35
Let me know if you have any issues running the code
(Note: the changes were made to the code created from the pip install which I'm not sure matches the code in your repository (https://github.com/brohrer)). If the code runs okay for you, perhaps i can create a pull request in your repo with the changes.
Regards, -Mike
Thanks Mike! So far it looks great to me. In order to make sure you get proper acknowledgement for your contribution there are two ways to play it.
Which do you prefer?
Brandon
On Sun, Nov 6, 2016 at 11:01 PM Mike Gold notifications@github.com wrote:
Hi Brandon,
I put my Becca 3.5 project here with the changes if you wanted to take a look:
https://github.com/microgold/Becca35
Let me know if you have any issues running the code
Regards, -Mike
— You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/brohrer/becca/issues/22#issuecomment-258742776, or mute the thread https://github.com/notifications/unsubscribe-auth/ABUS6UlEfhz73iQuqKYzOEKnOpbak-Eeks5q7qKRgaJpZM4KqJDo .
Hi Brandon, Whatever is easier for you. i'd be happy to branch and create a pull request if that easier. Best, Mike.
Sent via the Samsung GALAXY S® 5, an AT&T 4G LTE smartphone
-------- Original message -------- From: Brandon Rohrer notifications@github.com Date: 11/08/2016 7:43 PM (GMT-06:00) To: brohrer/becca becca@noreply.github.com Cc: Mike Gold mike@microgold.com, Author author@noreply.github.com Subject: Re: [brohrer/becca] Cool App! (#22)
Thanks Mike! So far it looks great to me. In order to make sure you get
proper acknowledgement for your contribution there are two ways to play it.
branches and note your contribution in the commit notice.
structure intact), make the changes, commit, and submit a pull request. The
advantage of this option is that your name is then permanently affiliated
with the codebase in a searchable way, rather than just being tucked away
in a note.
Which do you prefer?
Brandon
On Sun, Nov 6, 2016 at 11:01 PM Mike Gold notifications@github.com wrote:
Hi Brandon,
I put my Becca 3.5 project here with the changes if you wanted to take a
look:
https://github.com/microgold/Becca35
Let me know if you have any issues running the code
Regards,
-Mike
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/brohrer/becca/issues/22#issuecomment-258742776, or mute
the thread
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/brohrer/becca","title":"brohrer/becca","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/brohrer/becca"}},"updates":{"snippets":[{"icon":"PERSON","message":"@brohrer in #22: Thanks Mike! So far it looks great to me. In order to make sure you get\nproper acknowledgement for your contribution there are two ways to play it.\n\n1. I can copy and paste your changes into the current becca and becca_test\nbranches and note your contribution in the commit notice.\n\n2. You can fork the becca and becca_test branches (with all their directory\nstructure intact), make the changes, commit, and submit a pull request. The\nadvantage of this option is that your name is then permanently affiliated\nwith the codebase in a searchable way, rather than just being tucked away\nin a note.\n\nWhich do you prefer?\n\nBrandon\n\nOn Sun, Nov 6, 2016 at 11:01 PM Mike Gold \u003cnotifications@github.com\u003e wrote:\n\n\u003e Hi Brandon,\n\u003e\n\u003e I put my Becca 3.5 project here with the changes if you wanted to take a\n\u003e look:\n\u003e\n\u003e https://github.com/microgold/Becca35\n\u003e\n\u003e Let me know if you have any issues running the code\n\u003e\n\u003e Regards,\n\u003e -Mike\n\u003e\n\u003e —\n\u003e You are receiving this because you commented.\n\u003e\n\u003e\n\u003e Reply to this email directly, view it on GitHub\n\u003e \u003chttps://github.com/brohrer/becca/issues/22#issuecomment-258742776\u003e, or mute\n\u003e the thread\n\u003e \u003chttps://github.com/notifications/unsubscribe-auth/ABUS6UlEfhz73iQuqKYzOEKnOpbak-Eeks5q7qKRgaJpZM4KqJDo\u003e\n\u003e .\n\u003e\n-- \nhttp://brohrer.github.io/\n"}],"action":{"name":"View Issue","url":"https://github.com/brohrer/becca/issues/22#issuecomment-259314104"}}}
Thanks Mike. Forking and submitting a pull request is the easiest for me. If you have questions as you go through the process details, let me know. Brandon
On Tue, Nov 8, 2016 at 10:56 PM Mike Gold notifications@github.com wrote:
Hi Brandon, Whatever is easier for you. i'd be happy to branch and create a pull request if that easier. Best, Mike.
Sent via the Samsung GALAXY S® 5, an AT&T 4G LTE smartphone
-------- Original message -------- From: Brandon Rohrer notifications@github.com Date: 11/08/2016 7:43 PM (GMT-06:00) To: brohrer/becca becca@noreply.github.com Cc: Mike Gold mike@microgold.com, Author author@noreply.github.com Subject: Re: [brohrer/becca] Cool App! (#22)
Thanks Mike! So far it looks great to me. In order to make sure you get
proper acknowledgement for your contribution there are two ways to play it.
- I can copy and paste your changes into the current becca and becca_test
branches and note your contribution in the commit notice.
- You can fork the becca and becca_test branches (with all their directory
structure intact), make the changes, commit, and submit a pull request. The
advantage of this option is that your name is then permanently affiliated
with the codebase in a searchable way, rather than just being tucked away
in a note.
Which do you prefer?
Brandon
On Sun, Nov 6, 2016 at 11:01 PM Mike Gold notifications@github.com wrote:
Hi Brandon,
I put my Becca 3.5 project here with the changes if you wanted to take a
look:
https://github.com/microgold/Becca35
Let me know if you have any issues running the code
Regards,
-Mike
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/brohrer/becca/issues/22#issuecomment-258742776, or mute
the thread
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/brohrer/becca","title":"brohrer/becca","subtitle":"GitHub repository","main_image_url":" https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png ","avatar_image_url":" https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/brohrer/becca"}},"updates":{"snippets":[{"icon":"PERSON","message":"@brohrer in #22: Thanks Mike! So far it looks great to me. In order to make sure you get\nproper acknowledgement for your contribution there are two ways to play it.\n\n1. I can copy and paste your changes into the current becca and becca_test\nbranches and note your contribution in the commit notice.\n\n2. You can fork the becca and becca_test branches (with all their directory\nstructure intact), make the changes, commit, and submit a pull request. The\nadvantage of this option is that your name is then permanently affiliated\nwith the codebase in a searchable way, rather than just being tucked away\nin a note.\n\nWhich do you prefer?\n\nBrandon\n\nOn Sun, Nov 6, 2016 at 11:01 PM Mike Gold \u003cnotifications@github.com\u003e wrote:\n\n\u003e Hi Brandon,\n\u003e\n\u003e I put my Becca 3.5 project here with the changes if you wanted to take a\n\u003e look:\n\u003e\n\u003e https://github.com/microgold/Becca35\n\u003e\n\u003e Let me know if you have any issues running the code\n\u003e\n\u003e Regards,\n\u003e -Mike\n\u003e\n\u003e —\n\u003e You are receiving this because you commented.\n\u003e\n\u003e\n\u003e Reply to this email directly, view it on GitHub\n\u003e \u003chttps:// github.com/brohrer/becca/issues/22#issuecomment-258742776\u003e http://github.com/brohrer/becca/issues/22#issuecomment-258742776%5Cu003e, or mute\n\u003e the thread\n\u003e \u003chttps:// github.com/notifications/unsubscribe-auth/ABUS6UlEfhz73iQuqKYzOEKnOpbak-Eeks5q7qKRgaJpZM4KqJDo\u003e\n\u003e http://github.com/notifications/unsubscribe-auth/ABUS6UlEfhz73iQuqKYzOEKnOpbak-Eeks5q7qKRgaJpZM4KqJDo%5Cu003e%5Cn%5Cu003e .\n\u003e\n-- \nhttp://brohrer.github.io/\n http://brohrer.github.io/%5Cn"}],"action":{"name":"View Issue","url":" https://github.com/brohrer/becca/issues/22#issuecomment-259314104"}}}
— You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/brohrer/becca/issues/22#issuecomment-259329165, or mute the thread https://github.com/notifications/unsubscribe-auth/ABUS6Q0HtbzDre_qJjJCdgc-bu11OJnFks5q8UR9gaJpZM4KqJDo .
Closing due to a inactivity. Can re-open if needed.
Hey Brandon,
I just downloaded and installed becca. I had to tweak a few things in 3.5 in order to get it to work properly. Here are my notes:
This is awesome. Thanks for sharing this! I added a few notes to help me get this working. It may help others running with python 3.5
conda install numba if not already installed
In brain.py line 6 remove import pickle as CPickle and change to import pickle
fixed a tabbing issue and syntax error on line 283 of brain.py remove these lines: except pickle.PickleError, err: print('Error unpickling world: {0}'.format(err)) add these lines: except pickle.PickleError: print('Error unpickling world: ')
import becca_toolbox.feature_tools as ft, this line fails in In line 18 of image_1D.py comment out import becca_toolbox.feature_tools as ft
line 55 of tools.py change long to int (in 3.5 there is only int) if isinstance(shape, (int, int)):