Schema/update - Githubissues

broidHQ / integrations

Connect your App to Multiple Messaging Channels with the W3C Open standard.

https://www.broid.ai

GNU Affero General Public License v3.0

746 stars 83 forks source link

Schema/update #178

Open jeanbaptistemorin opened 7 years ago

jeanbaptistemorin commented 7 years ago

🤖 🤖, small PR on schemas!

Adding js-beautify to have readable output
The object.json looks more like a context.json according to the docs. "Object" in the documentation is more the base object of all the Objects, or a generic type for Context and Tags, right? Moved the object.json in context.json
Collections: moved to only Media items in activity for now, discussed with @killix
Object enum in tag.
id in context.

What do you think?

CLAassistant commented 7 years ago

All committers have signed the CLA.

jeanbaptistemorin commented 7 years ago

@killix thanks! Reverted the object/object back with

type: object
properties:
  id:
    type: string
  type:
    type: string
    enum: [ Note, Image, Video, Audio, Place, Document ]
required: [ id, type ]

to fit the doc. Is that correct?

Note for later: As Note, Media, Place... inherits object, maybe that inheritance could be mapped with a allOf later?

jeanbaptistemorin commented 7 years ago

Forgot the attachements. ✋ Will add that 🕐