broizter / DBM-Whitemane

DBM for Whitemane (Frostmourne)
https://github.com/broizter/DBM-Whitemane
8 stars 2 forks source link

Jaraxxus - An alert is being sent and timers drift every time Jaraxxus loses a stack of Nether Power #31

Closed broizter closed 18 hours ago

broizter commented 1 day ago

There seems to be a server bug where a spell_cast_success event is generated whenever a mage spellsteals the buff, causing a massive alert spam and timers going out of sync whenever the boss uses this ability and mages start spellstealing him.

It's causing these lines to trigger for every stack of Nether Power being spellstolen by a mage.

    elseif args:IsSpellID(66228, 67107, 67106, 67108) then  -- Nether Power
        timerNetherPowerCD:Start()
        specWarnNetherPower:Show(args.sourceName)
        specWarnNetherPower:Play("dispelboss")
        if timerPortalCD:GetRemaining() > 0 then
            timerPortalCD:AddTime(5)
        end
        if timerVolcanoCD:GetRemaining() > 0 then
            timerVolcanoCD:AddTime(5)
        end
        if timerFlameCD:GetRemaining() > 0 then
            timerFlameCD:AddTime(5)
        end
        if timerFleshCD:GetRemaining() > 0 then
            timerFleshCD:AddTime(5)
        end
        if timerFelFireballCD:GetRemaining() > 0 then
            timerFelFireballCD:AddTime(5)
        end
        if timerFelLightningCD:GetRemaining() > 0 then
            timerFelLightningCD:AddTime(5)
        end
        if timerTouchCD:GetRemaining() > 0 then
            timerTouchCD:AddTime(5)
        end
broizter commented 1 day ago

Workaround applied for now. This will make currently running timers go out of sync if not all stacks are dispelled before he uses the ability again, so I don't think its a good solution in the long term. May or may not be removed before next release. https://github.com/broizter/DBM-Whitemane/commit/1ce55c087cd710d803fd0bb9706223c36c9b8f96

Upstream issue created https://github.com/gamefreedomgit/Frostmourne/issues/2479

broizter commented 18 hours ago

Edge cases worked around so this should be fixed now and work properly. https://github.com/broizter/DBM-Whitemane/commit/53fd25bd78244dec7bba93bc9ad8bf4259c12567