Closed GoogleCodeExporter closed 9 years ago
The codes for (FactoryDynamicUI, ActivityDlgFilterInput) and
(ActionParameterViewFactory, ActivityDlgActionInput) looks very different even
though they are basically doing almost the same thing. Do you think it is
worthwhile to have them both look similar for the sake of uniformity (and
encourage code reuse) over the code base?
Original comment by renc...@gmail.com
on 8 Jul 2010 at 1:04
I do
Original comment by sv767%ny...@gtempaccount.com
on 8 Jul 2010 at 1:10
i++
Original comment by case.and...@gmail.com
on 8 Jul 2010 at 2:24
Code review: http://codereview.appspot.com/1758042
Caused by and correction detail: same as issue 100.
Test Cases (tested with OmniText, OmniPhoneNumber, OmniTimePeriod, OmniDate,
OmniArea):
1. Check that data entered in the fields are preserved when switching
activities:
1.1 With the FilterInputActivity open, go to home, then go back to omnidroid.
1.2 With the FilterInputActivity open, open the dialer my pressing the offhook button, go to home, then go back to omnidroid.
2. Create any rule with any filter and proceed to ActionInputActivity. Set
arbitrary data on the fields and change the orientation of the phone. The data
inputted should persists after the orientation has changed.
3. Create a new rule with two filters of the same type with different data.
Select one of the filter and open it with edit, then press back, choose the
other filter and do the same. The data from the other filter should not be
mixed up with the other filter.
Bug discovered while testing and created a new issue - issue 122.
Original comment by renc...@gmail.com
on 9 Jul 2010 at 5:22
Checked-in on r802.
Original comment by renc...@gmail.com
on 12 Jul 2010 at 6:33
Original issue reported on code.google.com by
renc...@gmail.com
on 7 Jul 2010 at 10:11