search

brok85 / omnidroid

Automatically exported from code.google.com/p/omnidroid
Apache License 2.0
0 stars 0 forks source link

Adding General Event Attributes #123

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Currently, the only attributes available while building a rule are those that 
come with the event but it might be nice to have some more general attributes 
available all the time, regardless of the event. Some examples might be current 
time, gps location, properties about the state of the phone, etc...

thoughts?

Original issue reported on code.google.com by c.r.dow...@gmail.com on 10 Jul 2010 at 12:26

GoogleCodeExporter commented 8 years ago 
Issue 109 (Time is) is related to this.

Original comment by case.and...@gmail.com on 10 Jul 2010 at 4:32

GoogleCodeExporter commented 8 years ago

Original comment by eligeler...@gmail.com on 13 Jul 2010 at 10:25

GoogleCodeExporter commented 8 years ago 
Issue 109 has been merged into this issue.

Original comment by eligeler...@gmail.com on 13 Jul 2010 at 10:38

GoogleCodeExporter commented 8 years ago 
Hello, have you started on this one? Do you mind if I take this?

Original comment by renc...@gmail.com on 19 Jul 2010 at 6:12

GoogleCodeExporter commented 8 years ago 
I started but you can take it. I picked up something else (Issue 122)

Original comment by eligeler...@gmail.com on 19 Jul 2010 at 8:13

GoogleCodeExporter commented 8 years ago 
Code review:
http://codereview.appspot.com/1849043

Change Summary:
Created new entries in the RegisteredEventAttributes Time and Location. These 
new entries has the FK_EventID set to -1, which is used as the indicator that 
these attributes are global to all events. These new entries also replace all 
the old entries like SMS Time, Phone Ring Time, Current Location, etc.

Test Cases:
Preparation: Create Rules with location and time filters. Also include actions 
that have event attribute tags with them (and also include one field with 
mutliple occurances of the same tag).

1. Install the new apk.
  1.1 Check the database if the filters are referencing the correct event attribute.
  1.2 Check the database if the tags are now converted to their generalized form.
2. View the old rules and check if they can be view, and are working properly 
(especially the filters and tags).
3. Create new rules with location and time filters. Check if it works properly.
4. Create new rules with actions that have event attribute tags. Check if it 
works properly.
5. Check whether events like Power Connected has Time and Location attributes.
6. Check that the time attribute is not duplicated in the SMS Received, Phone 
Ringing, Phone Ended and Time is Events.
7. Check that the location attribute is not duplicated in the GPS Location 
Changed Event.

Original comment by renc...@gmail.com on 23 Jul 2010 at 2:43

GoogleCodeExporter commented 8 years ago 
Checked-in @ r828.

Original comment by renc...@gmail.com on 25 Jul 2010 at 1:59