broken-e / DragDropConfirm

A simple shell extension for Windows to stop accidental drag and drop moves of folders.
Other
90 stars 25 forks source link

Global settings with per user language #29

Open pboettcher opened 2 years ago

pboettcher commented 2 years ago

In MUI systems like Windows 7 Utlimate the UI language is a per user setting, but this software takes sample strings from HKLM.

May be it is better to collect all the catch strings in all languages in an internal const array, with an additional ability to define "ItemText" in registry (or even more texts)?

bduffek commented 2 years ago

Just a disclaimer I am not the original developer, broken-e, nor am I experienced with programming. I just knew enough to look up how to make the changes I did make.

This comes up here too: https://github.com/broken-e/DragDropConfirm/issues/3

Since I am such a complete novice, perhaps a const array of strings is better than the idea there, which I never had time to implement?

Unfortunately when I first worked on this I had temporary hours at work with extremely generous time to work on things. We weren't able to use this since there isn't official QA and such unfortunately, but I tried to help out after that. Unfortunately my duties have expanded and I'm still catching up with many low priority work projects that piled up during the pandemic.

I do think having it check HKLU before checking HKLM is probably simply a matter of nesting the current check in another if statement. I don't know when I'd have time to personally look into it though. The last work I made was trying to figure out how to use multistrings for support for different checks at the same time, but I didn't have time to finish, but perhaps your idea is superior to that one. A release package needs to be made too, and I see the developer's instruction page is offline as well.

I do have control to approve pull requests if others wish to work on it, but I need more free time and need to relearn some of this stuff if were to touch it again personally.