search

brokkr / poca

A fast, multithreaded and highly customizable command line podcast client, written in Python 3
GNU General Public License v3.0
23 stars 4 forks source link

Deprecation: track_numbering #108

Closed brokkr closed 3 years ago

brokkr commented 6 years ago

Inserting fake track numbers into files feels like a really bad hack (and the implementation isn't much better than the feeling). It should get deprecated at some point.

It was intended as a solution to ordering when track numbers were missing but it seems to me now that that issue is better addressed using rename. Any player that I know of falls back on file names for ordering when track numbers are absent (if file names is not the only way of ordering). rename is solid and can be depended on to work: Just throw in the date at the start and you will get the right order (unless entries share pubdates?)

Renaming has the advantage of also solving the issue when simply viewing the files as files outside of a player.

The only advantage to fake tracknumbering is that the files may look more 'correct' in a player that displays track numbers (or uses non-filename ordering when track numbers are missing).

Against deprecation is that... we should have done it with 1.0. Deprecating in a point release after 1.0 feels wrong.

brokkr commented 6 years ago

Hmeah... Looks like we can restrict it to supported file types. It's not pretty but I think we can live with it for now.

brokkr commented 3 years ago

On second thought: I can't really get it to fail too badly. It might not be a good solution but it does no harm AFAICT.