search

brokkr / poca

A fast, multithreaded and highly customizable command line podcast client, written in Python 3
GNU General Public License v3.0
23 stars 4 forks source link

PyPi ready? #92

Closed brokkr closed 6 years ago

brokkr commented 6 years ago

http://peterdowns.com/posts/first-time-with-pypi.html

brokkr commented 6 years ago

The poca-poco distinction (script/package) made sense at the time but aparently it's not the correct PEP 423 way of doing things. So I made some last minute changes where poca is now the name of both project, script and package. And it seems to work.

NOTE: This breaks backwards compatibility even harder than before because old saved jars refer to poco instances rather than the new poca instances. On the plus side it gives us a really clear exception (ImportError) to look out for. When opening a jar gives us ImportError we know that it's because the db is old. We then tell the user as much.

Lesson: Don't save instances of your own types. Save lists, dictionaries, tuples, etc. Also, don't use pickle goldangit.

Upload to Pypi was meant for pypi-test. Not ideal but now it's there and the readme instructions have been updated.

IMPORTANT: Whenever a new release is about to get committed, you need to pre-insert the probable download_url into setup.py before it's actually there. That way pypi can get at the correct release.