Loadout issues to fix - Githubissues

Neefay commented 7 years ago

Stuff that needs to be fixed within the loadout sheets:

[x] Switch all RobertHammer pistols with their RHS variants wherever possible.
[x] Give long range to spotter not sniper.
[x] Snipers don't have ATRX and rangetables.
[x] Add _isBasicATDisposable tag to loadout sheets so that no extra ammo is given to disposable launchers and no backpacks are given.
[ ] Lower the amount of supplies for Rifleman (AT) rocket launchers, might be particularly important in Armastock.
[x] Update all structures and loadouts to include n Specialist AT/AA and Asst. for Weapons team.
[x] FTLs have no grenades. Huh?

Let's add whatever else here instead of opening new issues.

Coryf88 commented 7 years ago

[ ] Unknown where to use BRM_FMKUNIFORMS at. It seems the place it should be used would be in a loadout mod, using mod-list.sqf. However, the mod-list is included after the faction-list, which would result in the BRM_FMKUNIFORMS being set after it was checked.

Neefay commented 7 years ago

@Coryf88 I don't follow, where is this "BRM_FMKUNIFORMS*" you're referring to?

Coryf88 commented 7 years ago

BRM_FMK_UNIFORMS_AAFMKCamo BRM_FMK_UNIFORMS_CSATUrban BRM_FMK_UNIFORMS_MarinesWoodland BRM_FMK_UNIFORMS_NATOBlackMX BRM_FMK_UNIFORMS_USArmyCammo BRM_FMK_UNIFORMS_VDVCammo BRM_FMK_UNIFORMS_VDVMSV

Neefay commented 7 years ago

Oh yeah, those. I'll be honest: that was the last loadout enhancement I've added to the Framework back when I was remaking it into the addon, and like many other features, not even I recall how to use them, or if they do work.

IIRC, just throw them into the player Init script and it should work fine, but I'd have to test that out properly.

Coryf88 commented 5 years ago

[x] _optics isn't used. Only usage of it would be in fn_addOptics.sqf, however fn_addOptics.sqf overrides the values set in broma-misc-list.sqf
[x] Same as above, except for _battery
[x] ~~Seperate _optics into _opticsBinoc, _opticsRangefinder, and _opticsLaserdesignator.~~
[x] ~~Same as above, except for _battery, into _batteryLaser.~~
[ ] Several of the launchers have multiple ammo types specified, though it seems only the first ammo type is ever used.
[x] Crops should be Corps in "Royal Army Crops of Sahrani".
[x] Seems this would cause a script error, which would probably result in the Weapon not being added to the cargo. Though, addWeapon isn't used internally for cargo.
[x] Change GUN to RAMMO. [1, 2, 3, 4, 5]
[x] Change 1 to RAMMO [1, 2]
[x] Change 2 to GL [1, 2]
[x] _countCAT is nil in structures. The variable isn't in private-variables.sqf
[x] Some helmets are also NVGs (E.g. "H_PilotHelmetFighter_I"), applying NVGs after the helmet causes the helmet to be removed. player addHeadgear "H_PilotHelmetFighter_I"; player linkItem "NVGoggles_INDEP";. Example is an AAF Pilot.
[x] Change I_HMG_01_A_high_weapon_F to I_HMG_01_high_weapon_F [1]
[x] "JSDF": "TYRK_B_Carryall_JSDF" should be "TRYK_B_Carryall_JSDF"
[x] Look into: 10:48:47 TEST UNIT "B_Soldier_TL_F" ("EMPIRE") 10:48:47 [weapon rhs_weap_m38]: item[optic_Holosight] does not match to this weapon!
[x] The following

Also one of the main issues with the marksman rifle is that sometimes the RCO doesn't match with the commonRifle and the commonMarksman, like the SVD for example in some russian loadouts. One fix is to use the rail version of said gun but if it doesn't exist then we will always have this issue, I would suggest having another _commonDMRS or something like that just for the marksman rifle

Coryf88 commented 5 years ago

Content Errors

[x] Tests somehow missed:

_RPK74 is currently broken

Accessory

Protected

[x] _supG3: "hlc_muzzle_snds_g3"
[x] _supHK33: "hlc_muzzle_snds_HK33"
[x] _supM14: "hlc_muzzle_snds_M14"

Missing item

[x] _supFAL: "hlc_muzzle_snds_fal"

Weapons

Incompatible magazine

[x] _PCML: ["launch_NLAW_F","NLAW_F"]
[x] _P239C: ["hlc_pistol_P239_40","hlc_8Rnd_357SIG_B_P239"]
[x] _SR25: ["rhs_weap_sr25","rhsusf_20Rnd_762x51_m993_Mag"]
[x] _SR25EC: ["rhs_weap_sr25_ec","rhsusf_20Rnd_762x51_m993_Mag"]
[x] _AT4HEDP: ["rhs_weap_M136_hedp","rhs_m136_mag"]
[x] _AT4HP: ["rhs_weap_M136_hp","rhs_m136_mag"]
[x] _PMM: ["rhs_weap_makarov_pm","rhs_mag_9x18_12_57N181S"]

Multiple magazines

[ ] _RPG42: ["launch_RPG32_F","RPG32_F","RPG32_HE_F"]
[ ] _TitanAT: ["launch_I_Titan_short_F","Titan_AT","Titan_AP"]
[ ] _RPG32Ghx: ["launch_RPG32_ghex_F","RPG32_F","RPG32_HE_F"]
[ ] _TitanGhx: ["launch_O_Titan_short_ghex_F","Titan_AT","Titan_AP"]
[ ] _SMAW: ["rhs_weap_smaw","rhs_mag_smaw_HEAA","rhs_mag_smaw_HEDP"]
[ ] _GUSTAV: ["rhs_weap_maaws","rhs_mag_maaws_HEAT","rhs_mag_maaws_HE"]
[ ] _MAAWS: ["rhs_weap_maaws","rhs_mag_maaws_HEAT","rhs_mag_maaws_HE"]

Missing item

[x] _RPK12: "hlc_rifle_RPK12_60rnd"
[x] _HONEYBADGER: "hlc_rifle_honeybadger"
[x] _FNFALRHOD: "hlc_rifle_FAL5000_RH"
[x] _10rnd762AR10: "RH_20Rnd_762x51_AR10"
[x] _20rnd762M110: "RH_20Rnd_762x51_M80A1"
[x] _30rnd556M855: "RH_30Rnd_556x45_M855A1"
[x] _30rnd68SPC: "RH_30Rnd_68x43_FMJ"
[x] _30rndMK262: "RH_30Rnd_556x45_Mk262"
[x] _32rnd9mm: "RH_32Rnd_9mm_M822"
[x] _60rnd556M855: "RH_60Rnd_556x45_M855A1"
[x] _AR10: "RH_ar10"
[x] _HK416C: "RH_Hk416c"
[x] _HK416C: "RH_30Rnd_556x45_M855A1"
[x] _HK416D10: "RH_Hk416s"
[x] _HK416D10: "RH_30Rnd_556x45_M855A1"
[x] _HK416D14: "RH_Hk416"
[x] _HK416D14: "RH_30Rnd_556x45_M855A1"
[x] _M110: "RH_m110"
[x] _M110: "RH_20Rnd_762x51_M80A1"
[x] _MK11: "RH_Mk11"
[x] _MK12: "RH_mk12mod1"
[x] _MK12des: "RH_Mk12mod1_des"
[x] _MK12tg: "RH_Mk12mod1_tg"
[x] _MK12wdl: "RH_Mk12mod1_wdl"
[x] _SAMR: "RH_samr"
[x] _SBR9: "RH_sbr9"
[x] _SBR9: "RH_32Rnd_9mm_M822"
[x] _SBR9des: "RH_sbr9_des"
[x] _SBR9des: "RH_32Rnd_9mm_M822"
[x] _SBR9tg: "RH_sbr9_tg"
[x] _SBR9tg: "RH_32Rnd_9mm_M822"
[x] _SBR9wdl: "RH_sbr9_wdl"
[x] _SBR9wdl: "RH_32Rnd_9mm_M822"
[x] _VitorSBR: "RH_M4sbr_b"
[x] _VitorSBR: "RH_30Rnd_556x45_M855A1"
[x] _MAAWS: "tf47_m3maaws"
[x] _MAAWS: "tf47_m3maaws_HEAT"
[x] _MAAWS: "tf47_m3maaws_HE"
[x] _MAAWS: "tf47_m3maaws_HEDP"
[x] _MAAWS: "tf47_m3maaws_SMOKE"
[x] _MAAWS: "tf47_m3maaws_ILLUM"
[x] _AT4CSHEAT: "tf47_at4_heat"
[x] _AT4CSHEAT: "tf47_at4_m_HEAT"
[x] _AT4CSHEDP: "tf47_at4_HEDP"
[x] _AT4CSHEDP: "tf47_at4_m_HEDP"
[x] _AT4CSHP: "tf47_at4_HP"
[x] _AT4CSHP: "tf47_at4_m_HP"

Weapon has attachments "hlc_rifle_G36KA1KSK"

[ ] _G36KA1KSKGL: "HLC_Rifle_G36KSKAG36"

"rhs_weap_m27iar"

[ ] _M27IAR: "rhs_weap_m27iar_grip1"
[ ] _M27IARdes: "rhs_weap_m27iar_grip1"
[ ] _M27IARtg: "rhs_weap_m27iar_grip1"
[ ] _M27IARwdl: "rhs_weap_m27iar_grip1"
[ ] _RHSM27: "rhs_weap_m27iar_grip1"

"rhs_weap_m4_m320"

[x] _M4GL: "rhs_m4_m320"
[x] _RHSM4GL: "rhs_m4_m320"

"rhs_weap_m16a4"

[ ] _RHSM16A42: "rhs_weap_m16a4_grip"

"rhs_weap_m4_carryhandle"

[ ] _RHSM42: "rhs_weap_m4_carryhandle_grip3"

"rhs_weap_m4a1_blockII"

[ ] _RHSM4BLOCKII: "rhs_weap_m4a1_blockII_grip2"

"rhs_weap_mk18"

[ ] _RHSMK18MOD1: "rhs_weap_mk18_grip2"

"rhs_weap_hk416d10"

[ ] _RHSHK416D102: "rhs_weap_hk416d10_grip2"

"rhs_weap_hk416d145"

[ ] _RHSHK416D1452: "rhs_weap_hk416d145_grip2"

"rhsusf_weap_MP7A2"

[ ] _RHSMP7: "rhsusf_weap_MP7A2_grip3"

"rhsusf_weap_MP7A2_aor1"

[ ] _RHSMP7AOR1: "rhsusf_weap_MP7A2_aor1_grip3"

"rhsusf_weap_MP7A2_desert"

[ ] _RHSMP7DESERT: "rhsusf_weap_MP7A2_desert_grip3"

"rhsusf_weap_MP7A2_winter"

[ ] _RHSMP7WINTER: "rhsusf_weap_MP7A2_winter_grip3"

"rhs_weap_m24sws"

[x] _M24: "rhs_weap_m24sws"

"UK3CB_BAF_L110A2RIS"

[ ] _L110A2GRIP: "UK3CB_BAF_L110A2_FIST"

"UK3CB_BAF_L129A1"

[ ] _L129A1: "UK3CB_BAF_L129A1_AFG"
[ ] _L129A1GRIP: "UK3CB_BAF_L129A1_Grippod"

"UK3CB_BAF_L135A1"

[x] _L82A1: "UK3CB_BAF_L82A1"

"UK3CB_BAF_L85A2_RIS"

[x] _L85A2AFG: "UK3CB_BAF_L85A2_RIS_AFG"

"rhs_weap_rpg7"

[ ] _RPG7PGO: "rhs_weap_rpg7_pgo"

Protected

[x] _PMM: "rhs_weap_makarov_pmm"
[x] _30rnd545AK: "rhs_30Rnd_545x39_AK"
[x] _100rnd762PKP: "rhs_100Rnd_762x54mmR" // Issue with RHS
[x] _AK105: "rhs_30Rnd_545x39_AK"
[x] _AK105RIS: "rhs_30Rnd_545x39_AK"
[x] _AK105ZENIT: "rhs_30Rnd_545x39_AK"
[x] _AK105ZENITRIS: "rhs_30Rnd_545x39_AK"
[x] _AK74M: "rhs_30Rnd_545x39_AK"
[x] _AK74MRIS: "rhs_30Rnd_545x39_AK"
[ ] _AK74MDOUBLEMAG: "rhs_weap_ak74m_2mag"
[x] _AK74MDOUBLEMAG: "rhs_30Rnd_545x39_AK"
[ ] _AK74MCAMO: "rhs_weap_ak74m_2mag_camo"
[x] _AK74MCAMO: "rhs_30Rnd_545x39_AK"
[ ] _AK74FOLDED: "rhs_weap_ak74m_folded"
[x] _AK74FOLDED: "rhs_30Rnd_545x39_AK"
[x] _AK74DESERT: "rhs_30Rnd_545x39_AK"
[x] _AK74GP: "rhs_30Rnd_545x39_AK"
[x] _AK74GPRIS: "rhs_30Rnd_545x39_AK"
[x] _AK74MZENIT: "rhs_30Rnd_545x39_AK"
[x] _AK74MZENITRIS: "rhs_30Rnd_545x39_AK"
[x] _AK74MUUK: "rhs_30Rnd_545x39_AK"
[x] _AK74MUUKGL: "rhs_30Rnd_545x39_AK"
[x] _PKP: "rhs_100Rnd_762x54mmR" // Issue with RHS
[x] _PKM: "rhs_100Rnd_762x54mmR" // Issue with RHS
[x] _M4GL: "rhs_m4_m320"
[ ] _RHSMP7: "rhsusf_weap_MP7A2_grip3"
[ ] _RHSMP7AOR1: "rhsusf_weap_MP7A2_aor1_grip3"
[ ] _RHSMP7DESERT: "rhsusf_weap_MP7A2_desert_grip3"
[ ] _RHSMP7WINTER: "rhsusf_weap_MP7A2_winter_grip3"
[ ] _M136: "rhs_m136_mag"
[ ] _RPG26: "rhs_rpg26_mag"
[ ] _RSHG2: "rhs_rshg2_mag"
[ ] _AT4: "rhs_m136_mag"
[ ] _AT4HEDP: "rhs_m136_hedp_mag"
[ ] _AT4HP: "rhs_m136_hp_mag"
[ ] _M72A7: "rhs_m72a7_mag"
[ ] _AT4CSHEAT: "rhs_m136_mag"
[ ] _AT4CSHEDP: "rhs_m136_hedp_mag"
[ ] _AT4CSHP: "rhs_m136_hp_mag"
[x] _M4GL: "rhs_m4_m320"
[x] _RHSM4GL: "rhs_m4_m320"
[x] _M24: "rhs_weap_m24sws_blk"
[x] _L82A1: "UK3CB_BAF_L82A1"

Missing magazine

[x] _NLAW_3CB: ["UK3CB_BAF_NLAW_Launcher"]

Unexpected item category category=Magazine, type=Bullet

[x] _MP443: "rhs_mag_9x19_17"
[x] _GSH18: "rhs_mag_9x19_17"

category=Weapon, type=Handgun

[x] _MP443: "rhs_weap_pya"
[x] _GSH18: "rhs_weap_pya"

Unexpected item type category=Magazine, type=Artillery

[ ] _500rnd762M134: "hlc_500rnd_762x51_Belt"
[ ] _M134: "hlc_500rnd_762x51_Belt"
[ ] _5rndBuck: "rhsusf_5Rnd_00Buck"
[ ] _8rndBuck: "rhsusf_8Rnd_00Buck"
[ ] _M590S: "rhsusf_5Rnd_00Buck"
[ ] _M590L: "rhsusf_8Rnd_00Buck"

Coryf88 commented 5 years ago

Non-technical loadout issues

Help Wanted

[x] Several factions use a black color, which causes the faction name to be black on the ending screen, which has a black background. [AHKMA-PMC, MEC, TKARMY, TKMILITIA, ISIS, MUJAHIDEEN]
[x] Several factions are using MNP (Killoch’s Multi-National Pack) assets. [ANA, EMPIRE, FINNS, NORSF, UNION]
[x] "EMPIRE" using missing assets: "RH_python", "RH_6Rnd_357_Mag", "H_caf_ag_paktol_04"
[x] "NORSF" using missing assets: "T_HoodTan"
[x] "UNION" using missing assets: "H_caf_ag_paktol_04"
[x] "AFRICAN_ARMY" _factionStructure should be "MID-TIER"
[x] "LINGOR_ARMY" _factionStructure should be "MID-TIER"

Coryf88 commented 4 years ago

[ ] Check if there is a better location for BRM_FMK_UNIFORMS_* instead of init.sqf.

Coryf88 commented 2 years ago

[x] Remove: https://github.com/broma-arma/BromA-Framework-A3-Addon/blob/4a562b658158321dc6b36c0916112ce89706c961/loadouts/factions/structures/high_tier_army.sqf#L322

Reason: https://github.com/broma-arma/BromA-Framework-A3-Addon/blob/4a562b658158321dc6b36c0916112ce89706c961/loadouts/factions/structures/high_tier_army.sqf#L320

Simple fix, but I'm already changing a light bulb and don't want to end up in the Hal rabbit hole.

Speaking of rabbit holes...

[ ] _commonRCO high_tier_army.sqf: _isSquadLeader, _isReconAT mid_tier_army.sqf: None low_tier_army.sqf: _isRecon france_structure.sqf: _isOfficer, _isSquadLeader, _isTeamLeader, _isSpotter us_structure.sqf: _isSquadLeader
[ ] _commonCCO high_tier_army.sqf: _isTeamLeader mid/low_tier_army.sqf: _isSquadLeader, _isTeamLeader us_structure.sqf: None france_structure.sqf: _isRTO, _isRifleman, _isDemo, _isRiflemanAT, _isWeaponsAT, _isWeaponsATAssistant, _isWeaponsAA, _isWeaponsAAAssistant, _isAutoriflemanAsst, _isMMGAsst, _isGrenadier, _isLifeSaver, _isHMG, _isStaticAT, _isHMGTripod, _isATTripod, _isMortar, _isMortarAssistant, _isUAVOperator, default
[ ] _commonMAGNIFIED high/mid/low_tier_army.sqf, us_structure.sqf: _isSniper france_structure.sqf: _isMarksman, _isReconMarksman
[ ] _marksmanSCOPE us_structure.sqf: _isMarksman high/mid/low_tier_army.sqf: _isMarksman, _isReconMarksman france_structure.sqf: None
[ ] _commonSUPPRESSOR france_structure.sqf, mid/low_tier_army.sqf, us_structure.sqf: _isReconLeader, _isRecon, _isReconAT, _isReconMedic, _isReconDemo high_tier_army.sqf: _isReconLeader, _isRecon, _isReconAT, _isReconMarksman, _isReconMedic, _isReconDemo
[ ] TRACER rounds, See _countTracerRIFLE, are not given to _isReconLeader in france_structure.sqf
[ ] Possibly intentional, _countTracerMG not used in low_tier_army.sqf
[x] _countHE isn't used in any of the structures, check what it was used for Never used, only exists in the factions and was added in the Mission/Addon framework separation, so start of the addon. Possibly was meant to be used for HE launcher ammo?
[x] _rifleList, in cargo-list.sqf, should merge the magazines together and only add the unique ones.
[x] _rifleGLList isn't in private-variables.sqf and ammo for them isn't added in cargo-list.sqf, which should also be merged with the above

Coryf88 commented 3 months ago

[x] Go through and update previous tasks.
[x] Launcher isn't preloaded for RiflemanAT and ReconAT in all structures. Fix is to add ammo before launcher.
[x] GL/RifleGL isn't preloaded ...
[x] _commonAT is only used in France structure.
[ ] crewman, heli and jet pilot could use a vest.

broma-arma / BromA-Framework-A3-Addon

Loadout issues to fix #35

Accessory

Weapons

Non-technical loadout issues