Extending "fixingFirstReadings" PR to all cases - Githubissues

bromagosa / Snap4Arduino

Binding Snap! and Arduino together

http://snap4arduino.rocks

GNU Affero General Public License v3.0

133 stars 85 forks source link

Extending "fixingFirstReadings" PR to all cases #170

Closed jguille2 closed 7 years ago

jguille2 commented 7 years ago

Hi, I want to check the changes from fixingFirstReadings (#169) to all snap4arduino cases... but I want to confirm what I'm seeing before a new PR.

Chromium plugin

Its index.html includes s4a/threads.js and plugin/threads.js
But I don't see any modification (decoration) into the plugin script.
Then, I think we can delete plugin/threads.js and its inclusion into index.html

Android

The same case with its index.html and plugin/threads.js
And also there is a mobile/threads.js... but I don't see any inclusion of this file.

Linino

I think this case is different.
snap.js has s4a/threads.js inclusion and also a linino.js inclusion
But in this case, linino.js has changes and then, we need it, but we can apply these new fixes.

Conclusion

If the notes are right, I can make the changes into Chromium plugin (and I can test it before pulling).
I can make the changes into Android but I can't test this. If I do, I need to confirm that mobile/threads.js is not necessary.
I will not do any changes into Linino because I do not control it.

jguille2 commented 7 years ago

First readings already fixed in Chromium plugin.

If we discontinue full support to Android and Linino versions, we can close this issue.