search

bromagosa / Snap4Arduino

Binding Snap! and Arduino together
http://snap4arduino.rocks
GNU Affero General Public License v3.0
133 stars 85 forks source link

Updated CRE_Cirmata.ino. Fixed bug in servo control functions, for s… #264

Closed segertonGH closed 6 years ago

segertonGH commented 6 years ago

…wing arms and swing head. Updated servo wheel functions to SYSEX commands instead of native Firmata commands in an attempt to avoid missed commands from S4A. Added a new Demo mode, connect Pin 12 to GND on robot to activate and power on. Updated Creative_Robotix_xml to improve motors command responses.

jguille2 commented 6 years ago

Hi @segertonGH ,

We want to release a new version at the end of October. I'll update your lib before that.

I don't merge your PR because it introduces a hiden .vs folder into the code. Don't worry about this, I'll update your two files (xml and ino).

Anyway I want to share with you a comment about the libraries update... You know custom blocks are stored into the projects. So all the projects are using your blocks will continue with the old code. This is a big problem, because this is not obvious and users will have problems with broken relations between their Snap code and the firmata are using.

We can discuss about this... But the conclusion is easy, and it's the same for all the Snap! libraries system (but here it's more delicate because the firmware dependence): We can share a library if it does not change over time. If you want to continue developing it, maybe this library can not be into the core.

The purpose of this comment is to find the better way to help users. It may seem worse if they have to browse to a web page to find the xml file... but on the other hand, they'll find the right information: news, firmware related to these blocks... and if they update your firmware, they will also have the information that old projects should be updated.

Anyway, I'll update your files for the next version. Thank you!

Joan

segertonGH commented 6 years ago

Hi Joan,

Thanks (I was using visual studio IDE and I missed the inclusion of the .vs folder. Sorry about that).

The S4A library is now in a stable state and has enough functionality, so I'm happy to freeze the library at this point with no further updates so that you can include the library into the next release. I will also freeze the firmware, and will only service bug fixes and Bluetooth module updates.

All the best and good luck with the next release! Looking forwards to it!

Simon.

jguille2 commented 6 years ago

Closing this PR because #266 Thanks @segertonGH ! You could verify your changes into the master branch of Snap4Arduino.