bromagosa / Snap4Arduino

Binding Snap! and Arduino together
http://snap4arduino.rocks
GNU Affero General Public License v3.0
134 stars 85 forks source link

bug fixed with AUX port read and added delay between sampling #326

Closed segertonGH closed 6 months ago

segertonGH commented 6 months ago

With the Creative Robotix Library.

jguille2 commented 6 months ago

Hi Simon @segertonGH

I'm doing different changes to prepare Snap4Arduino 9, and your PR with 3 different commits for the same xml file wasn't the best for me... so I update that lib file with your latest version directly. So, current master version (that is could be the next relesased version) has already your update.

https://github.com/bromagosa/Snap4Arduino/commit/1c5854a5c563bb3d9329e81cc5fed9e3abedccac

Thanks, Joan

segertonGH commented 6 months ago

Hi Joan,

Many thanks, and sorry for the PR spam!

All the best,

Simon.

From: Joan Guillén i Pelegay @.> Sent: Wednesday, December 20, 2023 12:21 PM To: bromagosa/Snap4Arduino @.> Cc: Simon Egerton @.>; Mention @.> Subject: Re: [bromagosa/Snap4Arduino] bug fixed with AUX port read and added delay between sampling (PR #326)

Hi Simon @segertonGHhttps://github.com/segertonGH

I'm doing different changes to prepare Snap4Arduino 9, and your PR with 3 different commits for the same xml file wasn't the best for me... so I update that lib file with your latest version directly. So, current master version (that is could be the next relesased version) has already your update.

1c5854ahttps://github.com/bromagosa/Snap4Arduino/commit/1c5854a5c563bb3d9329e81cc5fed9e3abedccac

Thanks, Joan

— Reply to this email directly, view it on GitHubhttps://github.com/bromagosa/Snap4Arduino/pull/326#issuecomment-1863695512, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIKWAD7TLC5T5ZTC7GFHQKDYKI4QJAVCNFSM6AAAAABAY4YVPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRTGY4TKNJRGI. You are receiving this because you were mentioned.Message ID: @.**@.>>

La Trobe University | TEQSA PRV12132 - Australian University | CRICOS Provider 00115M