search

brombomb / f1hub

An angular app for F1 information
http://brombomb.github.io/f1hub/app/
MIT License
9 stars 7 forks source link

Wrong number representation #46

Closed ayush-wd closed 2 years ago

ayush-wd commented 2 years ago

The driver's number should not have a space between the space and the actual number. Ex. it should be '#33' not '# 33' Also Max Verstappen's number is '#1' however it is shown as '33' on the website

ayush-wd commented 2 years ago

I'm getting issues while trying to commit sir and now I am getting a message that I cannot comment on the previous issue right now.

brombomb commented 2 years ago

The results are pulled from permanent number which is Max's number. You can change it to use the parent object number to get #1 for Max instead of #33.

brombomb commented 2 years ago

I'm getting issues while trying to commit sir and now I am getting a message that I cannot comment on the previous issue right now.

I think I fixed the merging issue again. merge master into your branch, and make sure you have no merge conflicts

ayush-wd commented 2 years ago

Thank you sir, I think it's working now. You can accept the pull request now.

ayush-wd commented 2 years ago

The parent object number is present in which file?