search

brombomb / f1hub

An angular app for F1 information
http://brombomb.github.io/f1hub/app/
MIT License
8 stars 7 forks source link

Feature: Replace ergast with jolpica #89

Closed brombomb closed 2 weeks ago

brombomb commented 3 weeks ago

Data API is being deprecated at the end of the 2024 season. Move to the new API which should be a drop in replacement.

https://github.com/jolpica/jolpica-f1

Kannav02 commented 3 weeks ago

Hey @brombomb !

I've explored the codebase and I just wanted to clarify some points regarding the same

1) The controllers in the main.js file should support the new API and proper parsing of content should be made available to the respective views in the views folder 2) Look for any discrepancies with how the new API is handling the data, although I think this wouldn't be difficult as the new API has backward compatibility

if these are all the changes, I would love to work on this issue, thank you!

brombomb commented 3 weeks ago

Yup. It really should be as simple as a base URL swap. Just make a PR and reference this issue.

On Sun, Sep 29, 2024, 6:31 PM Kannav Sethi @.***> wrote:

Hey @brombomb https://github.com/brombomb !

I've explored the codebase and I just wanted to clarify some points regarding the same

  1. The controllers in the main.js file should support the new API and proper parsing of content should be made available to the respective views in the views folder
  2. Look for any discrepancies with how the new API is handling the data, although I think this wouldn't be difficult as the new API has backward compatibility

if these are all the changes, I would love to work on this issue, thank you!

— Reply to this email directly, view it on GitHub https://github.com/brombomb/f1hub/issues/89#issuecomment-2381760927, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIVSMEB2O5FSICWNWRLXX3ZZCLULAVCNFSM6AAAAABPCD2FDWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBRG43DAOJSG4 . You are receiving this because you were mentioned.Message ID: @.***>

Kannav02 commented 3 weeks ago

sure! I will start working on this

thank you!

Kannav02 commented 3 weeks ago

@brombomb just to clarify something before I make a change, angular isn't allowing me to make requests to the API due to CORS issues, is it okay if I use a proxy configuration to forward the request to the API?

brombomb commented 3 weeks ago

Can you make a PR marked as draft with he apo changes? Seems weird and I'm wondering if there's something else missing. I'd rather not add a proxy

Kannav02 commented 3 weeks ago

sure, I would do so just a quick update though, I went through the APIs repository, and an issue regarding CORS was raised 2 weeks ago, apparently, its fixed over there but I do get the CORS error when I make a request from angular,

Kannav02 commented 3 weeks ago

update, I found the fix

I went through another repo that was utilizing this API and found the fix, I'll get this working soon

brombomb commented 3 weeks ago

Awesome, thanks for the update!

On Mon, Sep 30, 2024 at 8:31 PM Kannav Sethi @.***> wrote:

update, I found the fix

I went through another repo that was utilizing this API and found the fix, I'll get this working soon

— Reply to this email directly, view it on GitHub https://github.com/brombomb/f1hub/issues/89#issuecomment-2384658321, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIVSMH4ZYWVSGDNNH2D3YDZZICORAVCNFSM6AAAAABPCD2FDWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBUGY2TQMZSGE . You are receiving this because you were mentioned.Message ID: @.***>

Kannav02 commented 3 weeks ago

Hey @brombomb

PR #91 should address and fix this issue

Thank you!

brombomb commented 2 weeks ago

Thanks for the PR and your patience!