bromite / bromite

Bromite is a Chromium fork with ad blocking and privacy enhancements; take back your browser!
https://www.bromite.org/
GNU General Public License v3.0
5.88k stars 383 forks source link

Continue playing video after screen lock. #2558

Closed AnimeAnalPRO closed 1 year ago

AnimeAnalPRO commented 1 year ago

Preliminary checklist

Can the bug be reproduced with corresponding Chromium version?

No

Bromite version

Bromite v108.0.5359.156 WebView

Device architecture

arm64-v8a

Android version

12.0

Device model

Poco X3 PRO MiUI 13.0.8.0

Changed flags

-

Is this bug about the SystemWebView?

Yes

Is this bug happening in an incognito tab?

Yes

Is this bug caused by the adblocker?

No

Is this bug a crash?

No

Describe the bug

Using the Via browser shell when watching videos on Youtube or other sites, the video continues to play with the sound with the screen locked. This error does not appear on the native SystemWebView.

Steps to reproduce the bug

Turn on any video and lock the screen.

Expected behavior

Maybe this error is the correct operation of BromiteWebView. If this is true, it may release a Magisk module to disable such a function.

Screenshots

-

n-buna404 commented 1 year ago

Tested and this is reproducible since I use this fairly evenly. Well if the contributor needs second opinion. I personally think that this bug/feature (background playback) is useful for me. Youtube even charge premium for this feature. The best case for both world if this can be toggle on or off via flags.

AnimeAnalPRO commented 1 year ago

Tested and this is reproducible since I use this fairly evenly. Well if the contributor needs second opinion. I personally think that this bug/feature (background playback) is useful for me. Youtube even charge premium for this feature. The best case for both world if this can be toggle on or off via flags.

I forgot to add that if you go back to the previous page with the "back" button during the video playback, the sound from the video will also be played. Yes, the function is useful, but I would like it to be optional

n-buna404 commented 1 year ago

For the second one, I cannot reproduce that. When I press back and page go to back to a previous page with video. There is no sound just the previous video media playback key will appear for short while then disappear (maybe because autoplay is blocked?).

I forgot to add that if you go back to the previous page with the "back" button during the video playback, the sound from the video will also be played. Yes, the function is useful, but I would like it to be optional

AnimeAnalPRO commented 1 year ago

For the second one, I cannot reproduce that. When I press back and page go to back to a previous page with video. There is no sound just the previous video media playback key will appear for short while then disappear (maybe because autoplay is blocked?).

I forgot to add that if you go back to the previous page with the "back" button during the video playback, the sound from the video will also be played. Yes, the function is useful, but I would like it to be optional

As for the latter, it may depend on the site.

theFireProject commented 1 year ago

Features not related to privacy

  • ...
  • allow playing videos in background tabs and disable pause on switching tabs

This is not a bug. The feature is mentioned in the README.

Background playback is extremely useful. Some platforms like YouTube block background playback on smartphones (on the website and in the app). This way you can bypass that restriction.