Question on v68 build issue

Version Version: v68.0.3440.72 Arch: arm64

Is the bug reproducible with latest version? Yes.

Can the bug be reproduced with corresponding Chromium version? Yes :(

Is the bug a crash? No.

Describe the bug I know this isn't a bug in Bromite, so feel free to tell me to go figure it out myself. I'm doing builds of Chromium and applying the Bromite patches. On v67.0.3396.107, I didn't have any issues with the build process, other than a patch that failed to apply without intervention. On latest Chromium v68.0.3440.72 I'm hitting a build error ninja: error: '../../third_party/libsync/src/sync.c', needed by 'obj/third_party/libsync/libsync/sync.o', missing and no known rule to make it. I thought it initially was an issue with the patches being applied, but I can reproduce the issue without any patching. Anyways, I'm mostly curious if you saw anything like this when moving from v67 to v68 builds?

To Reproduce Steps to reproduce the behavior:

Checkout Chromium branch v68.0.3440.72
Checkout Bromite v68.0.3440.72
Apply patches to Chromium
Try to build

Applying patches to Chromium
Cloning into '/home/ubuntu/bromite'...
Note: checking out '776d4f859e5d6b20cb7874dad97e3d50c0f684ba'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

Applying: Disable third-party cookies by default
Applying: Restore classic new tab page
Applying: battery_status_service: disable more privacy nightmares
Applying: Battery API: return nothing
Applying: google-cloud-messaging: disable experiment status check
Applying: updater: disable updater pings
Applying: prefs: only keep cookies until exit
Applying: Remove EV certificates
Applying: promo: disable Google promotion fetching
Applying: Disables omission of URL elements in Omnibox
Applying: Modify default preferences
Applying: Disable ads metrics by default
Applying: Do not store passwords by default
Applying: Disable NTP remote suggestions by default
Applying: Disable references to fonts.googleapis.com
Applying: Disable WebRTC by default
Applying: Disable data saver
Applying: Skip the first run and metrics
Applying: Disable signin and data saver preferences
Applying: Disable signin/data reduction promos
Applying: Removed Sync and Translate menu
error: removal patch leaves file contents
error: chrome/android/java/res/drawable-hdpi/settings_translate.png: patch does not apply
error: removal patch leaves file contents
error: chrome/android/java/res/drawable-mdpi/settings_translate.png: patch does not apply
error: removal patch leaves file contents
error: chrome/android/java/res/drawable-xhdpi/settings_translate.png: patch does not apply
error: removal patch leaves file contents
error: chrome/android/java/res/drawable-xxhdpi/settings_translate.png: patch does not apply
error: removal patch leaves file contents
error: chrome/android/java/res/drawable-xxxhdpi/settings_translate.png: patch does not apply
Patch failed at 0001 Removed Sync and Translate menu
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Applying: Never send any crash upload data
Applying: Hide "Send reports to Google"
Applying: Never fetch popular sites
Applying: ungoogled-chromium: Disable signin
.git/rebase-apply/patch:34: trailing whitespace.
#endif 
warning: 1 line adds whitespace errors.
Applying: ungoogled-chromium: Disable webRTC log uploader
Applying: ungoogled-chromium: Disable untraceable URLs
Applying: ungoogled-chromium: Disable translate integration
Applying: ungoogled-chromium: Disable profile avatar downloading
Applying: ungoogled-chromium: Disable intranet redirect detector
Applying: ungoogled-chromium: Disable Google host detection
Applying: ungoogled-chromium: Disable GCM
Applying: ungoogled-chromium: Disable Gaia
Applying: ungoogled-chromium: Clear HTTP cache menu item
Applying: Disable Omaha update checks
Applying: Add DuckDuckGo search engine
Applying: Add StartPage search engine
Applying: Add Google English-only engine
Applying: Add Qwant search engine
Applying: Fix crash when accessing page info / site settings
Applying: openH264: enable ARM/ARM64 optimizations
Applying: Cure AMP and tracking from search results
Applying: Play videos in background
Applying: Allow playing audio in background
Applying: Open YouTube links in Bromite
Applying: Add exit menu item
Applying: Remove help menu item
Applying: Add menu option to toggle global Javascript preference
Applying: url_request: hooks and ad url data
.git/rebase-apply/patch:33: trailing whitespace.

.git/rebase-apply/patch:73: trailing whitespace.

.git/rebase-apply/patch:75: trailing whitespace.

.git/rebase-apply/patch:79: trailing whitespace.

.git/rebase-apply/patch:84: trailing whitespace.

warning: squelched 12 whitespace errors
warning: 17 lines add whitespace errors.
Applying: Bromite adblock engine
Applying: User Agent: anonymize
Applying: AudioBuffer, AnalyserNode: fingerprinting mitigations via IDL
Applying: Canvas: fingerprinting mitigations for image data and webGL
Applying: getClientRects, getBoundingClientRect, measureText: add fingerprinting mitigation
Applying: Punt the Widevine version string
Applying: Disable metrics on all I/O threads
Applying: Add a flag for DNS-over-HTTPS
Applying: Always respect async dns flag (regardless of SDK version)
Applying: Add flag to configure maximum connections per host
Applying: Add flag to show/hide NTP tiles
Applying: Add flag to disable custom tab intents
Applying: Always allow partner customisation
Applying: Change default homepage to new tab page
Applying: Disable fetching of all field trials
Applying: Disable smooth scrolling on Linux
Applying: Disable plugins enumeration
Applying: Remove google account access permission on reboot
Applying: net/cert: increase default key length for newly-generated RSA keys
Applying: dns: send IPv6 connectivity probes to RIPE DNS rather than Google
Applying: profile-resetter: do not tick send-settings by default
Applying: browser-ui: disable warning about missing API keys
Applying: autofill: disable autofill download manager
Applying: first_run: deactivate autoupdate globally
Applying: safe_browsing: disable incident reporting
Applying: safe_browsing: disable reporting of safebrowsing override
Applying: safe_browsing: disable cookie transmission
Applying: extensions: always show component extensions in the ext list
Applying: translate: disable fetching of translate languages from server
Applying: lint: suppress hardcoded text warnings
Applying: kill Vision
Applying: kill GCM
.git/rebase-apply/patch:397: space before tab in indent.
        /*
.git/rebase-apply/patch:479: trailing whitespace.

warning: 2 lines add whitespace errors.
Applying: kill Auth
Applying: kill remaining Play Services checks
Applying: kill TOS and metrics opt-out
Applying: kill Translate(doesn't work)
Installing Debian sid i386 root image: /home/ubuntu/chromium/src/build/linux/debian_sid_i386-sysroot
Downloading https://commondatastorage.googleapis.com/chrome-linux-sysroot/toolchain/1015a998c2adf188813cca60b558b0ea1a0b6ced/debian_sid_i386_sysroot.tar.xz
Installing Debian sid amd64 root image: /home/ubuntu/chromium/src/build/linux/debian_sid_amd64-sysroot
Downloading https://commondatastorage.googleapis.com/chrome-linux-sysroot/toolchain/1015a998c2adf188813cca60b558b0ea1a0b6ced/debian_sid_amd64_sysroot.tar.xz
Done. Made 22472 targets from 1498 files in 7453ms
ninja: Entering directory `out/Default/'
ninja: error: '../../third_party/libsync/src/sync.c', needed by 'obj/third_party/libsync/libsync/sync.o', missing and no known rule to make it

Expected behavior Successful build.

bromite / bromite

Question on v68 build issue #96