search

brona / iproute2mac

CLI wrapper for basic network utilites on Mac OS X inspired with iproute2 on Linux systems - ip command.
MIT License
898 stars 73 forks source link

Color option is missing #21

Open ThangCZ opened 6 years ago

ThangCZ commented 6 years ago

The -c, -color option is missing. It's an essential part of iproute2. We should definitely support it!

naggie commented 6 years ago

This would be great. At least at first, the -c and -color options could be ignored such that aliases don't break.

brona commented 6 years ago

Ignoring shouldn't be a problem to maintain cli compatibility. Will be likely in next release. Full feature implementation however seems a bit tricky, I will have to review the underlying commands.

brona commented 3 months ago

Color option is now being ignored for script compatibility, keeping the FR open to implement it for real.

naggie commented 3 months ago

Thanks @brona !

silverwind commented 2 months ago

Color option is now being ignored for script compatibility, keeping the FR open to implement it for real.

Are you sure? I'm still seeing an error with latest version:

$ ip -c a
Option "-c" is unknown, try "ip help".
$ ip -V
iproute2mac, v1.5.2
brona commented 2 months ago

Color option is now being ignored for script compatibility, keeping the FR open to implement it for real.

Are you sure? I'm still seeing an error with latest version:

$ ip -c a
Option "-c" is unknown, try "ip help".
$ ip -V
iproute2mac, v1.5.2

Thank you for the report, fixied in v1.5.3. -color=never was already being parsed correctly (and ignored), however there was a bug for -c. You can track the release to Homebrew on https://github.com/Homebrew/homebrew-core/pull/181685