search

brona / iproute2mac

CLI wrapper for basic network utilites on Mac OS X inspired with iproute2 on Linux systems - ip command.
MIT License
898 stars 73 forks source link

Implement JSON output #51

Closed signal-09 closed 4 months ago

signal-09 commented 5 months ago

To implement JSON output, as in #49, I had to rewrite some functions.

There are many values not managed (e.g. link status, link enumeration, etc.) due to some lacks in ifconfig output compared to ip.

brona commented 5 months ago

Thanks for the PR, I will review it over the next 2 days.

brona commented 5 months ago

Few formalities before I look into the code itself - can you please:

Thanks

signal-09 commented 5 months ago

Few formalities before I look into the code itself - can you please:

  • [x] add a test case for the json output? see ./test/commands.sh
  • [x] add yourself to ./AUTHORS if interested
  • [x] suggest changes to the documentation? ./README.md

Thanks

Sure, done

signal-09 commented 5 months ago

If you want I can even go further with vlan link support (adding and removing).

signal-09 commented 5 months ago

Thanks! This is great. I would prefer to merge the json part first, then we can work on the bridge as a separate PR? I would like to e.g. make sure we don't duplicate some of the code, etc...

Ok, let's go with vlan staff in a second stage.

signal-09 commented 5 months ago

Sorry, I accidentally closed the pull request...

brona commented 4 months ago

Alright, I will merge it as is and then rework it a bit before the release.