bronnie313 / JavaScript-Capstone

MIT License
4 stars 0 forks source link

kanban board #21

Open bronnie313 opened 1 year ago

bronnie313 commented 1 year ago

Code review issue for kanban

AmaduKamara commented 1 year ago

Status: Required Changes ♻️ ♻️ ♻️

Hi @bronnie313,

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

✅ Added tasks lists correctly as expected 👍🏽

Required Changes ♻️

Check the comments under the review.

Task Assignment Sample

Screenshot 2023-03-27 at 5 49 26 PM

Your Task List

Screenshot 2023-03-27 at 5 38 53 PM

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

mckent05 commented 1 year ago

Hi team,

STATUS: APPROVED ✔️ ✔️

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations and well done! 🎉 approved

Highlights

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.