Closed tyru closed 8 years ago
And I found the difference of ExtraWhitespace's highlight. I don't know which one is correct. So I didn't change it.
ctermbg=darkred guibg=#382424
ColorScheme
event: ctermbg=red guibg=red
Sorry for the delay @hugomg and @tyru, been buried. It'll take another week or two but I'm looking forward to trying these PRs out.
It would help if anyone could give either of the open PRs a quick review.
Okay :)
Week or two? Arg, more like a month or two...
@tyru I like these changes, glad you made them separate commits.
Could you rebase against master? LGTM.
Now I rebased against master and git push --force
. Please check.
NOTE: I did small change to 5753ff3f3049bfd3e3b8567bb570158d6f2da648.
Before: \(\%u3000\|\s\)\+$
After: [\u3000[:space:]]\+$
Looks great, thanks!!
Hi. Thanks for developing a nice plugin! I found highlight is not customizable, and I needed 'IDEOGRAPHIC SPACE' character (U+3000) support. The character is used in CJK locale.
ShouldMatchWhitespace()
should be script-local :)