bronson / vim-trailing-whitespace

Highlights trailing whitespace in red and provides :FixWhitespace to fix it.
453 stars 62 forks source link

Make highlight customizable and U+3000 character support #14

Closed tyru closed 8 years ago

tyru commented 8 years ago

Hi. Thanks for developing a nice plugin! I found highlight is not customizable, and I needed 'IDEOGRAPHIC SPACE' character (U+3000) support. The character is used in CJK locale.

highlight ExtraWhitespace cterm=underline gui=underline ctermfg=4 guifg=Cyan
autocmd ColorScheme * highlight ExtraWhitespace cterm=underline gui=underline ctermfg=4 guifg=Cyan
tyru commented 8 years ago

And I found the difference of ExtraWhitespace's highlight. I don't know which one is correct. So I didn't change it.

bronson commented 8 years ago

Sorry for the delay @hugomg and @tyru, been buried. It'll take another week or two but I'm looking forward to trying these PRs out.

It would help if anyone could give either of the open PRs a quick review.

tyru commented 8 years ago

Okay :)

bronson commented 8 years ago

Week or two? Arg, more like a month or two...

@tyru I like these changes, glad you made them separate commits.

Could you rebase against master? LGTM.

tyru commented 8 years ago

Now I rebased against master and git push --force. Please check.

NOTE: I did small change to 5753ff3f3049bfd3e3b8567bb570158d6f2da648. Before: \(\%u3000\|\s\)\+$ After: [\u3000[:space:]]\+$

bronson commented 8 years ago

Looks great, thanks!!