search

brookesb91 / dismissible

:mega: Animated dismissible alerts.
MIT License
12 stars 5 forks source link

Fix the layout issue and the LineIcons dependency #10

Closed rodrigoodhin closed 1 year ago

rodrigoodhin commented 2 years ago

I've update the CSS class to fix the layout issue and I also added the LineIcons classes. I only added what is really necessary to LineIcons works as expected

brookesb91 commented 2 years ago

Thank you and apologies for the hiatus.

All looks good but shall look to review properly later today.

rodrigoodhin commented 2 years ago

Can I help with something?

brookesb91 commented 2 years ago

@rodrigoodhin I appreciate I've not been the most punctual and can only apologise.

Currently the build process is creating a build with a static version number and only when the master branch is pushed to. Ideally this will instead be triggered by tagging a new release and versioning accordingly.

The culprit file is https://github.com/brookesb91/dismissible/blob/master/.github/workflows/main.yml

rodrigoodhin commented 2 years ago

I've never did this on github, only on gitlab. Take a look at this gist https://gist.github.com/UVLabs/b5c3fc41eabee38b0601824aec0e97a0 I think is what are you looking for.

brookesb91 commented 2 years ago

I've added the changes to the workflow. Will run tests later today.

rodrigoodhin commented 2 years ago

Really Nice! Thanks!

sshaw commented 1 year ago

All this work fellaz, let's not let it go to waste! :shipit: