search

brookhong / Surfingkeys

Map your keys for web surfing, expand your browser with javascript and keyboard.
https://chrome.google.com/webstore/detail/surfingkeys/gfbliohnnapiefjpjlpjnehglfpaknnc
MIT License
5.29k stars 476 forks source link

1.17.0 Advanced settings do not take effect. #2166

Closed tamanishi closed 2 days ago

tamanishi commented 5 days ago

SurfingKeys: 1.17.0 Browser: 129.0.6668.60 (Official Build) (arm64) macOS Version 15.1

When Advanced mode is enabled, the contents of the Advanced settings do not take effect.

I checked the contents of the Advanced settings in Developer tools, it appears that the closing brackets are commented out.

Screenshot 2024-09-26 at 23 21 33 Screenshot 2024-09-26 at 22 55 02

The last line of the Advanced settings field does not end with a new line character.

Screenshot 2024-09-26 at 22 56 43
brookhong commented 5 days ago

Looks like there is a bug here. For now, could you just delete the last line then try?

tamanishi commented 5 days ago

Thank you for your confirmation. After removing the last comment line, the Advanced settings now take effect.

image

brookhong commented 2 days ago

Fixed in 1.17.1