brooklyn-data / dbt_artifacts

A dbt package for modelling dbt metadata. https://brooklyn-data.github.io/dbt_artifacts
Apache License 2.0
333 stars 126 forks source link

[Bug]: Fix linting action #383

Open glsdown opened 1 year ago

glsdown commented 1 year ago

Overview

Currently there are inconsistencies in the SQL scripts styles used (e.g. trailing vs leading commas). It's unclear if this is because the check was ignored when the files were amended, or if the check isn't working.

How to reproduce

Expected behaviour

All files to have consistent formatting.

Screenshots

Environment

Results of running dbt --version:

# Add the results here

Please paste the contents of your packages.yml file here:

packages:
  ...
poloaraujo commented 1 year ago

I can see the inconsistencies. I propose a giant PR that switches everything to leading commas. I'd be up for it!