brooklyn-data / dbt_artifacts

A dbt package for modelling dbt metadata. https://brooklyn-data.github.io/dbt_artifacts
Apache License 2.0
309 stars 113 forks source link

Fix: typo in upload_results to determine batch size #411

Closed rtkfan closed 5 months ago

rtkfan commented 7 months ago

Overview

Fixes a typo in upload_results() that causes batch sizes for uploading models to be too large for BigQuery only.

Update type - breaking / non-breaking

What does this solve?

This typo caused the batch size for models in BigQuery to be too large, causing an error (due to a too-large query size) when uploading models. Testing the same changeset on a different fork in a separate (complex, but private) project successfully uploads models (where using the v2.6.2 release of dbt_artifacts causes the failure).

Outstanding questions

N/A, this is a straightforward fix, I think!

What databases have you tested with?

This changeset passes integration tests in BigQuery. I don't have access to other databases so haven't tested there (however, the change should only affect behaviour in BigQuery).

jared-rimmer commented 5 months ago

Thanks for the spot and contribution @rtkfan!

matt-lam-thinkific commented 5 months ago

Thanks for pushing this through @jared-rimmer !